Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FFMPEG_PATH for Jellyfin 10.8.13+ support. Update Readme #901

Merged
merged 1 commit into from
May 19, 2024

Conversation

junkman690
Copy link

This request supersedes #900 and resolves #899. It sets FFMPEG_PATH to use the WOL compatible wrapper script for rffmpeg already in this mod to bring mod back into compatibility with Jellyfin 10.8.13 and 10.9 due to breaking change to allow user to set ffmpeg to a custom path using the webgui. Readme file updated to reflect this change and simplify slightly.

@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_901

@a-priestley a-priestley mentioned this pull request May 19, 2024
@aptalca aptalca merged commit 409371c into linuxserver:jellyfin-rffmpeg May 19, 2024
5 checks passed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong on this, but I think WOL should still work outside of host network mode when targeting the NAT'd WAN IP (see my NAT WoL instructions in this file), so long as the subnet is available to the container?

I don't have this configured currently, nor am I aware of how you would expose the subnet so I'd have to test it to be sure. Maybe it could be run in bridged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick search shows it might be possible but require additional setup depending if its a unicast, subnet broadcast or IP broadcast, however I am not sure how Docker's networking stack would handle these, nor do I have that setup in place to test with. I vaguely recall trying a few different methods before settling on using the WoL container as it meant there was no need to change router or switch settings to enable wake while still allowing Jellyfin to be NAT'd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants