Apply suggestions from code review

Signed-off-by: Howard Tseng <howardt12345@gmail.com>
linuxserver · Sep 29, 2024 · 18367bd · 18367bd
1 parent 77d1fef
commit 18367bd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/BuildImage.yml b/.github/workflows/BuildImage.yml
@@ -15,7 +15,7 @@ env:
   BASEIMAGE: "code-server" #replace
   MODNAME: "python3-poetry" #replace
   MOD_VERSION: ${{ inputs.mod_version }} #don't modify
-  MULTI_ARCH: "true" #set to false if not needed
+  MULTI_ARCH: "false"
 
 jobs:
   set-vars:

diff --git a/root/etc/s6-overlay/s6-rc.d/init-mod-code-server-python3-poetry-install/run b/root/etc/s6-overlay/s6-rc.d/init-mod-code-server-python3-poetry-install/run
@@ -10,6 +10,9 @@ echo "**** Setting up poetry ****"
 curl -sSL https://install.python-poetry.org | python3 -
 
 # Add poetry to the path
-echo "export PATH=\"\$HOME/.local/bin:\$PATH\"" >> /root/.bashrc
+echo "**** ensuring poetry is in PATH ****"
+if ! grep -q "$HOME/.local/bin" /var/run/s6/container_environment/PATH; then
+    printf ':$HOME/.local/bin' >> /var/run/s6/container_environment/PATH
+fi
 
 echo "**** poetry setup complete ****"