keep sanitized and raw external versions separate in external trigger #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Jun 3, 2025
github-project-automation
bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are sanitizing the external version and overwriting the variable. That causes unwanted issues when we later try to use that var value to check for artifacts.
This PR separates the raw and the sanitized versions of the var and uses the sanitized version only to check against the last pushed image version.