Skip to content

add SYFT_IMAGE_TAG env var #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add SYFT_IMAGE_TAG env var #63

wants to merge 1 commit into from

Conversation

aptalca
Copy link
Member

@aptalca aptalca commented Jun 10, 2025

Allow defining of syft image tag via env var
Print syft image tag used in logs
Default syft image tag to latest

Needs linuxserver/docker-jenkins-builder#344 merged to master first

@aptalca aptalca requested a review from a team June 10, 2025 14:39
@LinuxServer-CI LinuxServer-CI moved this to PRs Ready For Team Review in Issue & PR Tracker Jun 10, 2025
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-ci:a80a2536-pkg-a80a2536-dev-f74940f901addacae708700109ddffc058b296cb-pr-63

@thespad
Copy link
Member

thespad commented Jun 10, 2025

If we're defaulting to latest in linuxserver/docker-jenkins-builder#344 we should probably default to latest here too.

That said the causes of the 1.27.0 issues seem to be different between the two containers, so it might be better for now to leave this pinned at 1.26.1 - I'm not convinced it's even possible to work around the changes they've made.

Oh, also as it stands this will never fall back because the Jenkins builder defaults to latest if nothing is supplied to it so will always pass something to the CI container.

@aptalca
Copy link
Member Author

aptalca commented Jun 10, 2025

Then we'll have to merge the jenkins builder PR first and make sure the jenkins var is set to the same v1.26.1 value so the ci container can then build and push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs Ready For Team Review
Development

Successfully merging this pull request may close these issues.

3 participants