Skip to content

Ability to send text messages #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slowscript
Copy link
Contributor

I've added the ability to send and receive text messages. This could be useful for quickly sending URLs and tokens between devices and would fix #105
warpinator-msg_2

The messages can be selected and copied (selection, or whole message using the button). Up to 4 lines or first 120 characters are shown, although sometimes 4 lines can be exceeded due to wrapping. Unfortunately I did not figure out how to convince Gtk to properly ellipsize it, suggestions are welcome. Wrapping the text manually by inserting newlines looks the best, but then selecting and copying a part of it also includes the newlines... Another option would be to put the label in a ScrolledWindow, but I don't think that looks good. I think limiting the visible length in some way is needed to avoid having one message take up the whole window.

It also shows a notification:
msg-notification

I will add an identical feature to the Android and Windows versions later.

Display text message as a transfer in UI, show notification, allow copy text
Send message button and dialog
Copy link

@M0-find-U M0-find-U left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beenden

@M0-find-U
Copy link

I've added the ability to send and receive text messages. This could be useful for quickly sending URLs and tokens between devices and would fix #105

warpinator-msg_2

The messages can be selected and copied (selection, or whole message using the button). Up to 4 lines or first 120 characters are shown, although sometimes 4 lines can be exceeded due to wrapping. Unfortunately I did not figure out how to convince Gtk to properly ellipsize it, suggestions are welcome. Wrapping the text manually by inserting newlines looks the best, but then selecting and copying a part of it also includes the newlines... Another option would be to put the label in a ScrolledWindow, but I don't think that looks good. I think limiting the visible length in some way is needed to avoid having one message take up the whole window.

It also shows a notification:

msg-notification

I will add an identical feature to the Android and Windows versions later.

"Delete all"

@M0-find-U
Copy link

I've added the ability to send and receive text messages. This could be useful for quickly sending URLs and tokens between devices and would fix #105

warpinator-msg_2

The messages can be selected and copied (selection, or whole message using the button). Up to 4 lines or first 120 characters are shown, although sometimes 4 lines can be exceeded due to wrapping. Unfortunately I did not figure out how to convince Gtk to properly ellipsize it, suggestions are welcome. Wrapping the text manually by inserting newlines looks the best, but then selecting and copying a part of it also includes the newlines... Another option would be to put the label in a ScrolledWindow, but I don't think that looks good. I think limiting the visible length in some way is needed to avoid having one message take up the whole window.

It also shows a notification:

msg-notification

I will add an identical feature to the Android and Windows versions later.

@mtwebster mtwebster requested a review from clefebvre June 5, 2025 15:32
@mtwebster
Copy link
Member

Hi, I tested this out, some feedback:

  • We need to be able to detect that a remote has messaging capability (maybe our ServiceInfo needs to have an extra field to declare this?), and hide/disable messaging features if appropriate.
    image

  • New messages trigger a notification, but not a highlighting of the remote from the main view.
    image

  • I'm not a fan of having a popup to send a message - it's too many steps I think. What about having an entry at the bottom of the remote's page?
    (quick glade mock-up)
    image

  • Maybe we can improve the display of the received message to allow it to be wider:
    image
    You could hide the transfer_size_label for messages and add a new op_status_stack page with another, wider label (the one you're using now is 30px wide fixed).

I'd like to wait for @clefebvre's opinion on all of this stuff though - opinions tend to vary :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Send text
4 participants