Skip to content

CJS 6.2.0 fails to build with gobject-introspection 1.82.0 #123

@bobby285271

Description

@bobby285271
[120/123] Generating CjsPrivate-1.0.gir with a custom command (wrapped by meson to set env)
FAILED: CjsPrivate-1.0.gir 
env PKG_CONFIG_PATH=/nix/store/nqihxp634m083bn84ypc0s6kdd12n7pb-gobject-introspection-1.82.0-dev/lib/pkgconfig:/nix/store/qgfpbkw6kglzcpz45j6z2ry0yz7d5gx0-libffi-3.4.6-dev/lib/pkgconfig:/ni>
../libgjs-private/gjs-util.c:238: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.c:261: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.c:273: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.c:308: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.c:426: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.h:128: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.h:131: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.h:153: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
../libgjs-private/gjs-util.h:156: Warning: CjsPrivate: invalid "closure" annotation: only valid on callback parameters
<unknown>:: Fatal: CjsPrivate: warnings configured as fatal
<unknown>:: Fatal: CjsPrivate: warnings configured as fatal

I will say the relevant change is GNOME/gobject-introspection@d87d4f0, but I haven't done the bisect yet.

Looking at the --warn-error usages, I wonder if we can re-apply @rcalixte 's 58d7a32 for now, it looks like the changes are already presented on upstream in 1.79.1 though not in 1.77.2 which cjs is based on.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions