-
Notifications
You must be signed in to change notification settings - Fork 825
menu: Add context menu actions for favorites/recents #13220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I think this should be in the context menu (similar to what you get when right-clicking an application). This impacts the available width of the filename and path labels, and isn't consistent with the rest of the applet. |
29412e1 to
cebbe7f
Compare
Changed to the context menu action. |
450dc24 to
88fb376
Compare
88fb376 to
4adbf25
Compare
cec7133 to
ba8b357
Compare
eb099fe to
c3c8d19
Compare
7c8ce87 to
af0e5dd
Compare
af0e5dd to
2f15996
Compare
| _openContainingFolder() { | ||
| try { | ||
| Gio.DBus.session.call_sync( | ||
| "org.freedesktop.FileManager1", | ||
| "/org/freedesktop/FileManager1", | ||
| "org.freedesktop.FileManager1", | ||
| "ShowItems", | ||
| new GLib.Variant("(ass)", [ | ||
| [this._button.uri], | ||
| global.get_pid().toString() | ||
| ]), | ||
| null, | ||
| Gio.DBusCallFlags.NONE, | ||
| 1000, | ||
| null | ||
| ); | ||
| } catch (e) { | ||
| global.logError(`Could not open containing folder: ${e}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice, but only if your default file manager supports the FileManager service.
You could add a fallback that uses Gio.app_info_launch_default_for_uri() on the parent uri (you can use Gio.File methods to reliably get the parent uri). This won't 'select' the file but will at least follow through with opening the containing folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
fa43fe2 to
dbf6f05
Compare
Add `Remove from favorites` and `Open containing folder` action for favorites/recents.
dbf6f05 to
da22e34
Compare

Add
Remove from favoritesandOpen containing folderaction for favorites/recents, because you can't do this without using Nemo.