csd-power-manager.c: Sent property updates when the percentage changes, not just an icon. #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwebster
force-pushed
the
power-percent-updates
branch
from
a5f8f49 to
99dd804
Compare
changes, not just an icon. Commit c2c7609 removed the Tooltip property from csd-power. We weren't making use of that property anywhere in Cinnamon, but it was doing the work of triggering updates there whenever the battery percentage changed, keeping the applet up-to-date in between actual icon changes. There's no point in reverting everything - most is string handling that we still don't need. Instead, implement a simple percentage monitor and dbus Property to trigger updates for clients. Fixes linuxmint/cinnamon#13324.
mtwebster
force-pushed
the
power-percent-updates
branch
from
99dd804 to
43745ac
Compare
Member
Author
|
/generate-test-packages |
|
Test packages generated successfully! Download from the workflow run (available for 7 days). |
Contributor
|
Sorry for causing this regression. I think we should try to let the applet fetch the data from upower directly. |
Member
Author
|
It's ok, if we're not breaking things occasionally, we're not making enough of an effort :) cinnamon-settings' cs_power.py also accesses this stuff also, but that's definitely something to consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c2c7609 removed the Tooltip property from csd-power. We
weren't making use of that property anywhere in Cinnamon, but it
was doing the work of triggering updates there whenever the battery
percentage changed, keeping the applet up-to-date in between actual
icon changes.
There's no point in reverting everything - most is string handling
that we still don't need. Instead, implement a simple percentage
monitor and dbus Property to trigger updates for clients.
Fixes linuxmint/cinnamon#13324.