-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: unify audio pipeline with FFmpeg-based decoder and encoder #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
52f24cd
feat(audio): implement FFmpeg-based audio decoder
flexiondotorg 8704886
feat(audio): implement shared audio buffer for multi-consumer access
flexiondotorg 9ee7bd0
refactor: move ffmpeg-statigo submodule from vendor/ to third_party/
flexiondotorg 7ebc02b
feat(encoder): add direct audio sample input mode
flexiondotorg bb28655
refactor(audio): migrate to sample-based audio encoding
flexiondotorg 6806034
refactor(audio): standardize on FFmpeg-based audio decoding
flexiondotorg 3f40565
perf(ui): improve rendering performance and add thumbnail timing
flexiondotorg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| [submodule "vendor/ffmpeg-statigo"] | ||
| path = vendor/ffmpeg-statigo | ||
| [submodule "third_party/ffmpeg-statigo"] | ||
| path = third_party/ffmpeg-statigo | ||
| url = https://github.com/linuxmatters/ffmpeg-statigo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Repeated allocation in hot loop. Consider pre-allocating
audioSamplesBufferoutside the frame loop and reusing it with slicing (audioSamples := audioSamplesBuffer[:len(newSamples)]), consistent with howbarHeightsand other buffers are pre-allocated at lines 273-280.Prompt for AI agents