[IGNORE] Ci build images and push #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to use /workspace/images for actual VM images. Signed-off-by: Ian Campbell <ijc@docker.com>
|
do you want a review on this or is this WIP? |
|
This PR will only ever contain the same stuff as #8, basically it exists to simulate a CI run on master (i..e after a PR is merged) without actually pushing WIP nonsense to master, please ignore! |
ijc
force-pushed
the
ci-build-images
branch
9 times, most recently
from
6164829 to
dcd80fa
Compare
added 5 commits
November 24, 2017 15:07
Adds `linuxkit pkg push --nobuild` Signed-off-by: Ian Campbell <ijc@docker.com>
Needed for push Signed-off-by: Ian Campbell <ijc@docker.com>
In particular we want $pkg:$hash and $pkg:$hash-amd64 which are present if we built the package (rather than finding one to pull on hub). We will need the -amd64 one when we run `linuxkit pkg push`. Signed-off-by: Ian Campbell <ijc@docker.com>
RUNTIME={docker,cri-containerd} × NETWORK={weave,bridge}
Building the ISOs took long enough that things occasionally timed out during
testing. Perhaps increasing the resource class would help there, but for now
just build (and discard) tar versions of each.
Eventually it might be nice to publish the results as artifacts, however they
are quite large so doing so for every PR would be a bit much. Docker based
images are 1.5G (master) + 900M (node) and cri-containerd ones are 600M (for
both). Remember we would likely want iso-bios and iso-efi so doubling the size.
Signed-off-by: Ian Campbell <ijc@docker.com>
For now just cri-containerd and kubelet. The image cache packages use a different build system, they aren't updated so often so doing it manually is not so bad. An encrypted key is checked in, the passphrase is stored in the circle CI environment/secrets interface. Signed-off-by: Ian Campbell <ijc@docker.com>
ijc
force-pushed
the
ci-build-images
branch
4 times, most recently
from
a240c8e to
43f5079
Compare
Previous if you ran `make update-hashes` with a dirty tree then the `-dirty` suffix was sticky and would never be automatically removed (and might even multiply!). Also remove some unnecessary quotes. Signed-off-by: Ian Campbell <ijc@docker.com>
Merged
|
#8 merged, so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #8 but from a branch on the main repo not a fork in order to test push to hub (which requires secrets which aren't exposed to PRs based on forks).