-
Notifications
You must be signed in to change notification settings - Fork 0
fix(server): m2m token generation endpoint #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Asitha de Silva <asithade@gmail.com>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Caution Review failedThe pull request is closed. WalkthroughReplaced string interpolation with URL resolution for constructing the token endpoint in m2m-token.util.ts. All other logic, including request options, fetch invocation, error handling, and logging, remains unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes URL construction in the M2M token generation endpoint by removing a hardcoded slash to prevent double slashes in the final URL.
- Simplified URL concatenation logic in the
generateM2MTokenfunction - Changed from template literal with slash to direct string concatenation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Asitha de Silva <asithade@gmail.com>
🧹 Deployment RemovedThe deployment for PR #84 has been removed. |
✅ E2E Tests PassedBrowser: chromium All E2E tests passed successfully. Test Configuration
|
This pull request makes a small update to the
generateM2MTokenutility function. The change simplifies how thetokenEndpointURL is constructed by removing an unnecessary slash, which helps prevent double slashes in the final URL.