Skip to content

fix(ui): query service tag filtering #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

fix(ui): query service tag filtering #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions apps/lfx-pcc/src/app/shared/services/meeting.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ export class MeetingService {
}

public getMeetingsByProject(projectId: string, limit?: number, orderBy?: string): Observable<Meeting[]> {
// TODO: Replace tags with parent when API supports it
let params = new HttpParams().set('tags', `${projectId}`);
let params = new HttpParams().set('tags', `project_uid:${projectId}`);

if (limit) {
params = params.set('limit', limit.toString());
Expand All @@ -58,10 +57,9 @@ export class MeetingService {
}

public getUpcomingMeetingsByProject(projectId: string, limit: number = 3): Observable<Meeting[]> {
// TODO: Replace tags with parent when API supports it
// TODO: Replace start_time_gte with start_time_gte when API supports it
let params = new HttpParams().set('tags', `${projectId}`);
let params = new HttpParams().set('tags', `project_uid:${projectId}`);

// TODO: Add filter for upcoming meetings
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment is too vague and doesn't provide specific implementation guidance. Consider adding more details about what type of filter should be implemented (e.g., 'TODO: Add start_time_gte filter to only return meetings with start times after current date').

Suggested change
// TODO: Add filter for upcoming meetings
// TODO: Add start_time_gte filter to only return meetings with start times after the current date/time (i.e., upcoming meetings)

Copilot uses AI. Check for mistakes.
if (limit) {
params = params.set('limit', limit.toString());
}
Expand All @@ -70,10 +68,9 @@ export class MeetingService {
}

public getPastMeetingsByProject(projectId: string, limit: number = 3): Observable<Meeting[]> {
// TODO: Create new past meetings endpoint when new indexer is added
// TODO: Replace tags with parent when API supports it
let params = new HttpParams().set('tags', `${projectId}`);
let params = new HttpParams().set('tags', `project_uid:${projectId}`);

// TODO: Add filter for past meetings
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment is too vague and doesn't provide specific implementation guidance. Consider adding more details about what type of filter should be implemented (e.g., 'TODO: Add start_time_lte filter to only return meetings with start times before current date').

Suggested change
// TODO: Add filter for past meetings
// TODO: Add end_time_lte filter to only return meetings with end times before the current date/time

Copilot uses AI. Check for mistakes.
if (limit) {
params = params.set('limit', limit.toString());
}
Expand Down
2 changes: 1 addition & 1 deletion apps/lfx-pcc/src/server/services/meeting.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class MeetingService {
public async getMeetingById(req: Request, meetingUid: string): Promise<Meeting> {
const params = {
type: 'meeting',
tags: meetingUid,
tags: `meeting_uid:${meetingUid}`,
};

const { resources } = await this.microserviceProxy.proxyRequest<QueryServiceResponse<Meeting>>(req, 'LFX_V2_SERVICE', '/query/resources', 'GET', params);
Expand Down