Repository navigation
feat(meetings): meeting details v2 redesign - #3249
Draft
nunoeufrasio wants to merge 25 commits into
Draft
nunoeufrasio wants to merge 25 commits into
nunoeufrasio wants to merge 25 commits into
Conversation
nunoeufrasio
added
do-not-merge
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This was referenced Oct 4, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The draft release remains intentionally incomplete and has unresolved past-roster contract inconsistencies.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
This draft integration PR establishes the meeting-details V2 foundation behind the existing feature flag while preserving V1.
Changes:
- Adds the SSR-safe V1/V2 gate and V2 scaffold.
- Adds view-model resolvers, tests, and scoped design tokens.
- Documents the redesign’s state model, requirements, selectors, and architecture.
| File | Description |
|---|---|
AGENTS.md |
Documents scoped token exception. |
.claude/rules/development-rules.md |
Adds V2 testid guidance. |
.claude/rules/styling.md |
Defines scoped token rules. |
apps/lfx-one/e2e/meetings-v2-flag-gate.spec.ts |
Tests the page gate end-to-end. |
apps/lfx-one/src/app/app.routes.ts |
Routes meeting details through the gate. |
apps/lfx-one/src/app/modules/meetings/meeting-details-gate/meeting-details-gate.component.html |
Selects deferred V2 or V1. |
apps/lfx-one/src/app/modules/meetings/meeting-details-gate/meeting-details-gate.component.spec.ts |
Tests gate states and fallback. |
apps/lfx-one/src/app/modules/meetings/meeting-details-gate/meeting-details-gate.component.ts |
Implements hydration-safe flag gating. |
apps/lfx-one/src/app/modules/meetings/meeting-details-page/meeting-details-page.component.html |
Adds the temporary V2 scaffold. |
apps/lfx-one/src/app/modules/meetings/meeting-details-page/meeting-details-page.component.ts |
Defines the V2 page component. |
apps/lfx-one/src/app/modules/meetings/meeting-details-page/meeting-details-page.tokens.scss |
Adds scoped visual tokens. |
apps/lfx-one/src/app/modules/meetings/meeting-join-v1/meeting-join.component.html |
Moves the unchanged V1 template. |
apps/lfx-one/src/app/modules/meetings/meeting-join-v1/meeting-join.component.spec.ts |
Moves the unchanged V1 tests. |
apps/lfx-one/src/app/modules/meetings/meeting-join-v1/meeting-join.component.ts |
Moves the unchanged V1 component. |
docs/architecture/frontend/component-architecture.md |
Documents the dual-tree architecture. |
docs/architecture/frontend/public-meeting-join.md |
Updates V1 location and gate behavior. |
docs/architecture/frontend/styling-system.md |
Documents scoped token layers. |
docs/architecture/shared/package-architecture.md |
Documents Angular compiler test setup. |
packages/shared/src/interfaces/index.ts |
Exports V2 interfaces. |
packages/shared/src/interfaces/meeting-view-model.interface.ts |
Defines V2 view-model contracts. |
packages/shared/src/utils/index.ts |
Exports V2 resolvers. |
packages/shared/src/utils/meeting-calendar.utils.spec.ts |
Clarifies compiler preloading. |
packages/shared/src/utils/meeting-view-model.utils.spec.ts |
Tests resolver matrices. |
packages/shared/src/utils/meeting-view-model.utils.ts |
Implements V2 state resolvers. |
packages/shared/src/utils/meeting.utils.ts |
Centralizes meeting-end timing. |
specs/011-meeting-details-redesign/README.md |
Indexes the feature specification. |
specs/011-meeting-details-redesign/checklists/requirements.md |
Adds specification checks. |
specs/011-meeting-details-redesign/data-model.md |
Documents payload-to-state mapping. |
specs/011-meeting-details-redesign/design-token-deviations.md |
Records token deviations. |
specs/011-meeting-details-redesign/requirements.md |
Defines functional requirements. |
specs/011-meeting-details-redesign/spec.md |
Defines scope and rollout invariants. |
specs/011-meeting-details-redesign/state-matrix.md |
Defines viewer/state behavior. |
specs/011-meeting-details-redesign/testid-contract.md |
Defines stable test selectors. |
specs/011-meeting-details-redesign/v2-scaffold.md |
Defines V1/V2 structure and retirement. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 4, 2026
nunoeufrasio
added a commit
that referenced
this pull request
Oct 5, 2026
* docs(meetings): add the v2 rollout and retirement plan Adds specs/011-meeting-details-redesign/rollout.md for V2-03. It separates the two controls: the integration branch decides whether the code is in production at all (nothing reaches main until release PR #3249), and MEETING_V2_ENABLED_FLAG decides who sees V2 once it is. Defines eight stages (build, release, internal testers, extended testers, signed-in percentage, anonymous, soak, retire), each with who decides and exit criteria. States that the code default never changes and targeting is the switch. Gives the anonymous plan: a code change that needs #2920's server-side evaluation, then an anonymous LaunchDarkly context ramped by percentage. Adds what is measured, a rollback table, and flag retirement: this page drops its read of the shared flag, and the flag itself retires only with the composer. The V1-deletion checklist is filed as #3266. The README's contents table now lists the files that actually exist. Refs #2875 Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com> * docs(meetings): reconcile v2 spec cross-references after the merge The foundation PRs (#2909, #2910, #2911, #2913, #2914, #2935) now sit together on feat/meeting-details-v2, so the "pending sibling, not on main yet" notes they carried are stale. They become plain cross-references in spec.md, state-matrix.md, data-model.md, requirements.md, testid-contract.md, v2-scaffold.md and the meeting-view-model resolver comments. Also records the newly filed Phase 1 issues (#3250-#3265) in spec.md's work order and requirements.md's traceability table, and the V1 retirement issue #3266. Refs #1766 Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com> * docs(meetings): fix rollout plan gating and rollback guidance Make #2920 the stage 4 entry gate rather than a release blocker, scope R05 and FR-001 to the stages before the anonymous stage, give the V1 rollback a targeted-revert path, and stop reusing the D-2 label. Refs #2875 Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com> * docs(meetings): address review feedback on the rollout plan Make FR-001 platform-neutral with the signed-in and post-hydration rules scoped to their stages, limit stage 2 to signed-in states, define the baseline once a V1 cohort is gone, and re-wrap a spec paragraph. Refs #2875 Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrasio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The release PR remains intentionally incomplete and has unresolved feature-gate and documentation issues.
Review effort: Balanced
Findings: 1
Open (7)
Resolved since last review (1)
4 tasks done
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
This draft release remains incomplete and has unresolved logout cleanup, duplicate auto-join, and future SSR consistency issues.
Review effort: Balanced
Findings: 4
Open (10)
Comment on lines
+41
to
+44
| <span class="block bg-[var(--md-accent)] py-[1.5px] text-[8px] font-bold uppercase tracking-[0.05em] text-[var(--md-surface-card)]">{{ | ||
| startTime | date: 'MMM' | ||
| }}</span> | ||
| <span class="flex flex-1 items-center justify-center text-[16px] font-bold text-[var(--md-text-heading)]">{{ startTime | date: 'd' }}</span> |
| protected readonly userMenuItems: MenuItem[] = [ | ||
| { label: 'Profile', icon: 'fa-light fa-user', routerLink: '/profile' }, | ||
| { separator: true }, | ||
| { label: 'Logout', icon: 'fa-light fa-sign-out', url: '/logout', target: '_self' }, |
Comment on lines
+115
to
+118
| * The attempt is the page's, not this instance's (`claimAutoJoin`), so a remounted slot does not | ||
| * open the meeting again. Known limitation until V1 is retired: on a full page load V1 mounts | ||
| * first, and if its join URL resolves before the feature flag, V1 auto-joins too, so the viewer can | ||
| * get a second tab of the same link. V1 cannot be edited to coordinate (R01). |
Comment on lines
+135
to
+137
| | Token | V2 value | Nearest `lfxColors` | Difference | Adopt upstream? | | ||
| | ----------------- | --------- | ------------------- | ---------- | ---------------------- | ------------------------------------------------------------------- | ------------------------------ | | ||
| | `--md-feature-ai` | `#7c3aed` | n/a | n/a | `violet.600` `#7F22FE` | AI-summary icon only (non-text); prototype violet is less saturated | Yes — converge on `violet.600` | |
* feat(meetings): add the v2 invitation-required action Closes #2879 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): address pre-pr review of the invitation-required action Refs #2879 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): format the organizer email date in the meeting timezone Refs #2879 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The draft remains incomplete, and the current V1-to-V2 transition can trigger duplicate automatic joins.
Review effort: Balanced
Findings: 4
Open (10)
* feat(meetings): add the v2 register action Closes #2878 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): address pre-pr review of the register action Refs #2878 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): scope a page registration to its own meeting Refs #2878 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): keep the register handler before private members Refs #2878 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): key the optimistic registration to its meeting Refs #2878 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It remains an incomplete draft and contains unresolved credential-replay, SSR-timezone, TransferState-retirement, and documentation issues.
Review effort: Balanced
Findings: 1
Open (11)
Previously missed (2)
In code that hasn't changed since last review
specs/011-meeting-details-redesign/v2-scaffold.md:73
This ownership description is stale: MeetingDetailsStateService now derives viewer role, privacy, meeting status, action slot, early-join eligibility, and the shared sign-in URL. Saying the sections derive those states independently misdocuments the centralization that prevents sections from disagreeing.
specs/011-meeting-details-redesign/v2-scaffold.md:110
Directly routing to the page removes the only MeetingDetailsSeedService provider, while the page state service injects it optionally. The browser would then ignore the server's ready/error TransferState seed, refetch, and initially render a different branch. Include relocating seed ownership in this checklist rather than asserting that the page needs no change.
Comment on lines
+107
to
+110
| <a | ||
| [href]="signInHref()" | ||
| class="hidden h-[34px] flex-none items-center whitespace-nowrap rounded-full border border-[var(--md-border-strong)] px-[15px] text-[13px] font-semibold text-[var(--md-text-heading)] hover:bg-[var(--md-surface-hover)] focus-visible:shadow-[var(--md-shadow-focus)] focus-visible:outline-none min-[641px]:inline-flex" | ||
| data-testid="meeting-identity-bar-create-account"> |
* feat(meetings): add the v2 guest join form Closes #2882 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): address pre-pr review of the guest join form Refs #2882 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): reject a blank guest name and drop a duplicate log Refs #2882 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Guest-email changes can expose a stale join link, while V2 also omits deferred analytics tracking and dynamic document titles.
Review effort: Balanced
Findings: 2
Open (14)
Comment on lines
+125
to
+129
| // A field edited back to invalid since the fetch: hold Join until the form is valid again. | ||
| if (value && this.form.invalid) { | ||
| return { status: 'idle' }; | ||
| } | ||
| return { status: 'ready', url: buildJoinUrlWithParams(link.url, null, { name: value.name?.trim(), organization: value.organization?.trim() }) }; |
Comment on lines
+60
to
+63
| public constructor() { | ||
| // An IntersectionObserver rather than a scroll listener, re-attached whenever the header element | ||
| // changes (it exists only in the `ready` branch). `afterRenderEffect` never runs on the server. | ||
| afterRenderEffect((onCleanup) => { |
Comment on lines
+47
to
+49
| export class MeetingDetailsPageComponent { | ||
| protected readonly state = inject(MeetingDetailsStateService); | ||
| protected readonly userService = inject(UserService); |
* feat(meetings): load the viewer's own rsvp on the v2 page Closes #2880 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): address pre-pr review of the viewer's own rsvp Refs #2880 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): retry and scope the viewer's rsvp, and surface bff failures Refs #2880 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): read rsvp lookups strictly and keep a saved rsvp Refs #2880 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
It is an incomplete 75-file draft spanning public SSR and BFF behavior, with an unresolved strict RSVP pagination defect.
Review effort: Balanced
Findings: 2
Open (15)
| return null; | ||
| } | ||
|
|
||
| const registrants = await this.getMeetingRegistrantsForUser(req, meetingUid, email, username); |
* feat(meetings): add the v2 rsvp card Closes #2881 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): address pre-pr review of the rsvp card Refs #2881 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): keep an in-flight rsvp save on its own occurrence Refs #2881 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Guest joins can use a stale email-specific URL, uninvited organizers are offered unusable RSVP controls, and the release remains an explicitly incomplete draft.
Review effort: Balanced
Findings: 2
Open (16)
Comment on lines
+270
to
+272
| if (input.viewerRole === 'organizer' || input.viewerRole === 'registrant') { | ||
| if (input.inviteResponsesEnabled) { | ||
| return 'rsvp'; |
* feat(meetings): explain v2 meetings without rsvp tracking Closes #3263 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> * fix(meetings): address pre-pr review of the no-rsvp-tracking state Refs #3263 Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> --------- Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
This draft combines 78 files across SSR routing, public access, RSVP behavior, and an explicitly unfinished multi-phase release.
Review effort: Balanced
Findings: 2
Open (16)
Signed-off-by: Nuno Eufrásio <nmeufrasio@gmail.com> # Conflicts: # packages/shared/src/constants/meeting.constants.ts
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The draft remains incomplete, and the current RSVP and guest-join implementations contain unresolved correctness defects.
16 open findings
🧠 Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why it's open now
quality-check.yml(lint, types, unit tests, build) only triggers on PRs intomain, so every merge intofeat/meeting-details-v2re-runs it here.Merged into the integration branch so far
specs/011-meeting-details-redesign/spec.md)AGENTS.md: needs code-owner review)@lfx-one/shared)/meetings/:id+ V2 scaffold; V1 moved tomeeting-join-v1/byte-identicalspecs/011-meeting-details-redesign/rollout.md)docs/architecture/frontend/meeting-surface-boundary.md)MeetingDetailsStateService) and the gate's TransferState seed handofflfx-headeron V2): date tile, status subtitle, sign-in / account menuresolvePrivacy)meetingStatus(adds "Starting soon" before the scheduled start)rollout.md)data-my-rsvp,setMyRsvp; BFF/rsvp/menow surfaces lookup failuresrsvp-unavailablestate, off-state pinnedStill to build before this merges
See
specs/011-meeting-details-redesign/spec.md§ Work order:rollout.md). E0-03 awaits the Permissions owner's confirmation of the organizers-only Manage role (asked on docs(meetings): record the public and admin meeting surface boundary #3268).meetingStatus.Before marking ready
feat/meeting-details-v2mainmerged into the integration branch, with CI green hereCloseslines added for every issue the epic resolves (sub-PRs targeted a non-default branch, so their closing keywords didn't fire)AGENTS.mdline (feat(meetings): add scoped design tokens for meeting details v2 #2911)🤖 Generated with Claude Code