Skip to content

Conversation

@justforlxz
Copy link
Member

@justforlxz justforlxz commented Jan 28, 2026

Jan 28 11:10:58 honor-laptop (treeland)[811]: treeland.service: PrivateIPC=yes is configured, but IPC namespace setup failed, ignoring: Operation not permitted
Jan 28 11:10:58 honor-laptop (treeland)[811]: treeland.service: Failed to set up mount namespacing: /dev/mqueue: Operation not permitted
Jan 28 11:10:58 honor-laptop (treeland)[811]: treeland.service: Failed at step NAMESPACE spawning /usr/bin/treeland: Operation not permitted
Jan 28 11:10:58 honor-laptop systemd[703]: treeland.service: Main process exited, code=exited, status=226/NAMESPACE
Jan 28 11:10:58 honor-laptop systemd[703]: treeland.service: Failed with result 'exit-code'.

PrivateIPC: This option is only available for system services, or for services running in per-user instances of the service manager in which case PrivateUsers= is implicitly enabled (requires unprivileged user namespaces support to be enabled in the kernel via the "kernel.unprivileged_userns_clone=" sysctl).

Security controls for the treeland-user service have been temporarily removed. They will be added back after further confirmation of the options.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the treeland systemd service unit by removing several hardening/security directives that were preventing the service from starting, trading off systemd-level security restrictions for reliable startup while deferring a more targeted fix to a later change.

File-Level Changes

Change Details Files
Relax systemd hardening settings on the treeland user session service to resolve startup failures.
  • Remove NoNewPrivileges setting from the treeland service unit
  • Remove OOMScoreAdjust and Nice adjustments that altered process scheduling/oom behavior
  • Remove MemoryDenyWriteExecute to allow writable/executable memory mappings needed during startup
  • Remove PrivateIPC to allow IPC sharing with other processes as required by treeland
  • Remove ProtectSystem and ProtectProc restrictions that limited filesystem and /proc visibility
  • Remove RestrictSUIDSGID to permit running or interacting with setuid/setgid binaries if needed by treeland
misc/systemd/dde-session-pre.target.wants/treeland.service.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

…ce startup issue

```
Jan 28 11:10:58 honor-laptop (treeland)[811]: treeland.service: PrivateIPC=yes is configured, but IPC namespace setup failed, ignoring: Operation not permitted
Jan 28 11:10:58 honor-laptop (treeland)[811]: treeland.service: Failed to set up mount namespacing: /dev/mqueue: Operation not permitted
Jan 28 11:10:58 honor-laptop (treeland)[811]: treeland.service: Failed at step NAMESPACE spawning /usr/bin/treeland: Operation not permitted
Jan 28 11:10:58 honor-laptop systemd[703]: treeland.service: Main process exited, code=exited, status=226/NAMESPACE
Jan 28 11:10:58 honor-laptop systemd[703]: treeland.service: Failed with result 'exit-code'.
```

> PrivateIPC: This option is only available for system services, or for services running in per-user instances of the service manager in which case PrivateUsers= is implicitly enabled (requires unprivileged user namespaces support to be enabled in the kernel via the "kernel.unprivileged_userns_clone=" sysctl).

Security controls for the treeland-user service have been temporarily removed. They will be added back after further confirmation of the options.

Log:
PrivateIPC=true
ProtectSystem=full
ProtectProc=invisible
RestrictSUIDSGID=true No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少换行

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants