Skip to content

Conversation

@Whale107
Copy link
Contributor

adjust indeterminateprogressbar color

Log:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#597
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 13, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#597
QPen pen;
pen.setWidth(1);
pen.setColor(QColor(0, 0, 0, int(0.2 * 255)));
pen.setColor(isDarkType ? QColor(255, 255, 255, int(0.1 * 255)) : QColor(0, 0, 0, int(0.1 * 255)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重复代码,放在变量里

adjust indeterminateprogressbar color

Log:
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 15, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#597
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • paintEvent函数中,使用DGuiApplicationHelper::instance()->themeType()来判断主题类型,但没有考虑到DGuiApplicationHelper可能未正确初始化的情况。
  • paintEvent函数中,使用DGuiApplicationHelper::adjustColor调整颜色时,没有考虑到颜色调整的范围可能不合适,可能会导致颜色效果不理想。
  • paintEvent函数中,d->m_sliderWidget->width() < d->m_spotWidget->width() / 2的判断逻辑可能存在问题,因为d->m_sliderWidget->width()d->m_spotWidget->width()的单位可能不同,可能导致比较不准确。
  • paintEvent函数中,radius变量在多次使用前没有进行初始化,这可能会导致在绘制圆角矩形时出现问题。
  • paintEvent函数中,QMargins(1, 1, 1, 1)被直接使用,但没有考虑到m_sliderWidget->geometry()的大小变化可能导致边距不合适。
  • paintEvent函数中,p.setClipPath(clipPath);调用后,没有检查返回值,可能会导致剪切路径未正确设置。

是否建议立即修改:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, Whale107

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Whale107 Whale107 merged commit ef29656 into linuxdeepin:dev/animation Aug 15, 2024
Whale107 added a commit to Whale107/dtkwidget that referenced this pull request Sep 23, 2024
adjust indeterminateprogressbar color

Log:
deepin-bot bot pushed a commit that referenced this pull request Sep 23, 2024
adjust indeterminateprogressbar color

Log:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants