-
Notifications
You must be signed in to change notification settings - Fork 9
feat: support Qt 6.10 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dtklog. Source-pull-request: linuxdeepin/dtklog#18
Synchronize source files from linuxdeepin/dtklog. Source-pull-request: linuxdeepin/dtklog#18
Signed-off-by: ComixHe <heyuming@deepin.org>
Synchronize source files from linuxdeepin/dtklog. Source-pull-request: linuxdeepin/dtklog#18
deepin pr auto review我来审查这段代码变更: CMakeLists.txt 变更分析:
if("${QT_VERSION_MAJOR}" STREQUAL "6")
if ("${Qt6Core_VERSION}" VERSION_GREATER_EQUAL 6.10.0)
find_package(Qt6 REQUIRED COMPONENTS CorePrivate)
TARGET_LINK_LIBRARIES(${library_target} PRIVATE Qt${QT_VERSION_MAJOR}::CorePrivate)
endif()
endif()dloghelper.cpp 变更分析:
总结建议:
这些改进将使代码更加健壮,提高兼容性,并便于维护。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, ComixHe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtklog. Source-pull-request: linuxdeepin/dtklog#18
No description provided.