Skip to content

fix: add missing UosMilitary edition type cases#475

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
May 19, 2025
Merged

fix: add missing UosMilitary edition type cases#475
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Contributor

Added case 9 to return UosMilitary/UosMilitaryS in uosEditionType
function
The change was necessary because the system needs to recognize edition
type 9 as a valid military edition variant
This ensures proper handling of all supported UOS edition types in the
system

fix: 添加缺失的 UosMilitary 版本类型处理

在 uosEditionType 函数中添加了 case 9 返回 UosMilitary/UosMilitaryS 的
处理
此变更是必要的,因为系统需要将类型9识别为有效的军事版本变体
这确保了系统中对所有支持的 UOS 版本类型的正确处理

pms: BUG-316837

Added case 9 to return UosMilitary/UosMilitaryS in uosEditionType
function
The change was necessary because the system needs to recognize edition
type 9 as a valid military edition variant
This ensures proper handling of all supported UOS edition types in the
system

fix: 添加缺失的 UosMilitary 版本类型处理

在 uosEditionType 函数中添加了 case 9 返回 UosMilitary/UosMilitaryS 的
处理
此变更是必要的,因为系统需要将类型9识别为有效的军事版本变体
这确保了系统中对所有支持的 UOS 版本类型的正确处理

pms: BUG-316837
@18202781743 18202781743 requested review from BLumia and mhduiy May 19, 2025 08:57
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • uosEditionType函数中,case 9被重复添加了两次,这可能是代码错误。
  • case 9被添加了两次,但返回的值不同,这可能会导致逻辑错误。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 19, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#475
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Contributor Author

/forcemerge

18202781743 pushed a commit to linuxdeepin/dtk6core that referenced this pull request May 19, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#475
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 19, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit cac4439 into linuxdeepin:master May 19, 2025
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants