Skip to content

Conversation

@asterwyx
Copy link
Contributor

@asterwyx asterwyx commented May 15, 2025

Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass the version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang wangyixue@deepin.org

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 19, 2025

TAG Bot

New tag: 5.7.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #476

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 5, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 5, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 5, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
18202781743
18202781743 previously approved these changes Jun 6, 2025
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 6, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt文件中,读取VERSION文件并设置DTK_VERSION变量是一个好的做法,但需要确保VERSION文件的内容格式正确,并且不会因为文件读取错误而导致版本号设置失败。

  2. archlinux/PKGBUILD文件中,移除了-DBUILD_WITH_SYSTEMD=ON-DDTK_VERSION=$version的设置,这可能会影响构建过程。需要确认这是否是有意为之,并且相关的依赖项和配置是否已经更新以适应这一变化。

  3. debian/rules文件中,移除了-DBUILD_VERSION=$(BUILD_VER)-DDTK_VERSION=$(PACK_VER)的设置,这同样可能会影响构建过程。需要确认这是否是有意为之,并且相关的依赖项和配置是否已经更新以适应这一变化。

  4. .reuse/dep5文件中,添加了VERSIONFiles列表中,这可能是为了确保版本文件被包含在依赖管理中。但是,需要确保这个更改不会导致其他依赖管理工具出现问题。

  5. .syncexclude文件中,添加了VERSION到排除列表中,这可能是为了防止版本文件被同步到其他位置。但是,需要确保这个更改不会导致版本文件在需要时无法访问。

  6. CMakeLists.txt文件中,使用file(READ)string(STRIP)来读取和清理版本号是一个好的做法,但需要确保VERSION文件的存在和正确性。

  7. archlinux/PKGBUILDdebian/rules文件中,使用了awk来提取版本号,这是一个简单有效的方法,但需要确保pkgver的格式始终符合预期。

总体来说,这些更改看起来是为了更新版本号,但需要确保相关的依赖项和配置都已经更新以适应这些变化。同时,需要确保这些更改不会引入新的问题,例如构建失败或依赖管理问题。

Use VERSION file to manage DTK version. VERSION file defines package
version. It also decides the initial value of cached variable
DTK_VERSION which controls the project version in cmake build system.
VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION
file. One can still pass version to DTK_VERSION when running cmake
configure. This is helpful for developers.

Signed-off-by: Yixue Wang <wangyixue@deepin.org>
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Jun 6, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#474
@asterwyx asterwyx changed the title BREAKING_CHANGE: remove compile argument DTK_VERSION feat: Support VERSION file Jun 6, 2025
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit 81e3d9c into linuxdeepin:master Jun 6, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants