fix: resolve compilation failure on Qt 6.9 #466
Conversation
Updated the dvtablehook.h file to adjust the typedef for Fun2ReturnType based on changes in Qt 6.9 interfaces. Additionally, the main.cpp file now casts the unicode value to short to prevent type issues. These changes are necessary to ensure compatibility with the latest Qt framework and to resolve the build issues that arise from interface modifications. 修复: 解决在Qt 6.9上的编译失败 更新了dvtablehook.h文件，以根据Qt 6.9接口的变化调整Fun2ReturnType的 typedef。此外，main.cpp文件现在将unicode值转换为short，以防止类型问题。 这些更改对于确保与最新Qt框架兼容以及解决接口修改引起的构建问题是必要的。
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#466
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tools/dconfig2cpp/main.cpp:18
- The static_cast to short may introduce negative values if ch.unicode() exceeds the max positive range for a signed short. Please ensure that the downstream interface expects a signed short and that this conversion will not lead to unintended behaviors.
result += QString("\u%1").arg(static_cast<short>(ch.unicode()), 4, 16, QChar('0'));
include/util/dvtablehook.h:226
- [nitpick] The updated typedef now uses '::type' instead of '::Value' for Fun2ReturnType to align with Qt 6.9 API changes. It might be helpful to add an inline comment explaining the conditional change for future code maintenance.
typedef typename QtPrivate::FunctorReturnType<Fun2, typename QtPrivate::List_Left<typename FunctionPointer<Fun1>::Arguments, Fun2ArgumentCount>::Value>::type Fun2ReturnType;
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#466
|
TAG Bot TAG: 5.7.14 |
update changelog to 5.7.14
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#466
deepin pr auto review代码审查意见：
84 |
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#466
2 participants
Updated the dvtablehook.h file to adjust the typedef for Fun2ReturnType based on changes in Qt 6.9 interfaces. Additionally, the main.cpp file now casts the unicode value to short to prevent type issues. These changes are necessary to ensure compatibility with the latest Qt framework and to resolve the build issues that arise from interface modifications.
修复: 解决在Qt 6.9上的编译失败
更新了dvtablehook.h文件，以根据Qt 6.9接口的变化调整Fun2ReturnType的 typedef。此外，main.cpp文件现在将unicode值转换为short，以防止类型问题。
这些更改对于确保与最新Qt框架兼容以及解决接口修改引起的构建问题是必要的。