feat: dconfig2cpp always add bindableFoo functions on Qt6#461
Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom Mar 6, 2025
Merged
feat: dconfig2cpp always add bindableFoo functions on Qt6#461zccrs merged 1 commit intolinuxdeepin:masterfrom
zccrs merged 1 commit intolinuxdeepin:masterfrom
Conversation
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Mar 6, 2025
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#461
Direct string literal for the property name, because the literal was use on the Q_PROPERTY macro, so use the hex encode for the property name strings can't avoid the Chinese text codec problems.
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Mar 6, 2025
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#461
Contributor
deepin pr auto review代码审查意见:
总体来说,代码的修改提高了可读性和可维护性,同时通过条件编译确保了代码的兼容性。建议进一步优化重复代码,并确保所有用户输入都得到适当的处理。 |
18202781743
approved these changes
Mar 6, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6core
that referenced
this pull request
Mar 6, 2025
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct string literal for the property name, because the literal was use on the Q_PROPERTY macro, so use the hex encode for the property name strings can't avoid the Chinese text codec problems.