Skip to content

chore: update translations#341

Merged
lzwind merged 2 commits intolinuxdeepin:masterfrom
Lighto-Ku:new-master
Jun 26, 2025
Merged

chore: update translations#341
lzwind merged 2 commits intolinuxdeepin:masterfrom
Lighto-Ku:new-master

Conversation

@Lighto-Ku
Copy link
Contributor

@Lighto-Ku Lighto-Ku commented Jun 26, 2025

as title

Log: update translations
Bug: https://pms.uniontech.com/bug-view-321607.html

Summary by Sourcery

Update and correct translation files for the Deepin Deb Installer’s English locales

Chores:

  • Replace incorrect Arabic and other non-English entries in en_AU.ts with the original English source text
  • Align en_US.ts translation entries to exactly match the updated source strings
  • Merge and standardize multi-line uninstall confirmation messages into single-line source and translation entries

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lighto-Ku

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 26, 2025

Reviewer's Guide

This PR updates the Australian and US English translation files by replacing unintended non-English translations with the original English source strings and cleaning up formatting and whitespace in TS files.

File-Level Changes

Change Details Files
Synchronize en_AU translations to match source English
  • Replaced Arabic translations with English for prompts, buttons and status messages
  • Updated loading and error messages to use original English text
  • Ensured every tag matches its string
translations/deepin-deb-installer_en_AU.ts
Synchronize en_US translations to match source English
  • Replaced Arabic and Russian translations with English for install/uninstall dialogs
  • Updated button labels (Show details, Collapse, Confirm, etc.) to English
  • Aligned compatibility mode messages and dependency alerts with source text
translations/deepin-deb-installer_en_US.ts
Clean up whitespace and formatting in TS files
  • Removed inconsistent indentation and tabs inside tags
  • Merged multi-line translations into single lines
  • Trimmed extra spaces around tags and attributes
translations/deepin-deb-installer_en_AU.ts
translations/deepin-deb-installer_en_US.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 翻译一致性:代码中的翻译从阿拉伯语变更为英文,这可能会导致用户界面在不同语言环境下的一致性问题。建议确认是否所有界面都需要支持多语言,并确保翻译的一致性。

  2. 注释和文档:代码中没有添加或更新注释和文档,这对于维护和理解代码非常重要。建议在必要时添加注释,特别是对于复杂的逻辑和重要的代码段。

  3. 代码格式:代码格式在提交中有所变化,例如缩进和空格的使用。虽然这不是语法错误,但保持一致的代码格式有助于提高代码的可读性和可维护性。

  4. 翻译内容:在翻译内容中,有些翻译可能没有完全遵循原文的语义,例如“جارٍ تحميل الحزم...”被翻译为“Loading packages...”,这可能不是完全准确的翻译。建议确保翻译的准确性。

  5. 按钮文本:按钮文本如“OK”、“Cancel”和“Install”等在多语言环境下应该保持一致,以避免用户混淆。建议检查所有按钮文本以确保一致性。

  6. 错误信息:错误信息如“Installation failed, insufficient disk space”和“Parsing failed: An illegal file structure was found in the manifest file!”等应该保持清晰和准确,以便用户理解问题所在。

  7. 用户提示:用户提示信息如“Please go to Control Center to enable developer mode and try again. Proceed?”等应该清晰明了,并给出明确的操作步骤。

总体来说,代码审查主要集中在翻译的一致性、注释和文档的添加、代码格式的保持、翻译的准确性、按钮文本的一致性、错误信息和用户提示的清晰度等方面。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Lighto-Ku - I've reviewed your changes - here's some feedback:

  • Verify that reverting all translations to English in the en_AU and en_US TS files is intentional and that the original Arabic (and other) translations have been migrated into their correct locale files.
  • Several multiline source strings (e.g. uninstall confirmation messages) have been collapsed into single lines—please confirm that the UI still renders their formatting and line breaks correctly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Verify that reverting all translations to English in the en_AU and en_US TS files is intentional and that the original Arabic (and other) translations have been migrated into their correct locale files.
- Several multiline source strings (e.g. uninstall confirmation messages) have been collapsed into single lines—please confirm that the UI still renders their formatting and line breaks correctly.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

@Lighto-Ku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
deepin-auto-translation 1e6b93c link true /test deepin-auto-translation

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

as title

Log: update changelog
@github-actions
Copy link

TAG Bot

TAG: 6.5.23
EXISTED: no
DISTRIBUTION: unstable

@lzwind lzwind merged commit e442e5a into linuxdeepin:master Jun 26, 2025
18 of 20 checks passed
@lzwind
Copy link

lzwind commented Jun 27, 2025

/topic cd-20250627

@deepin-ci-robot
Copy link

Add topic: cd-20250627 successed.

@lzwind
Copy link

lzwind commented Jun 27, 2025

/integr-topic cd-20250627

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#2959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants