Skip to content

Conversation

@swq11
Copy link
Contributor

@swq11 swq11 commented Jul 23, 2024

@deepin-bot
Copy link

deepin-bot bot commented Jul 24, 2024

TAG Bot

New tag: 0.0.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #77

@swq11 swq11 force-pushed the fix_9893 branch 14 times, most recently from 2a1e56a to bb440f5 Compare July 26, 2024 07:08
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swq11, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Jul 26, 2024

TAG Bot

New tag: 0.0.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #82

@swq11 swq11 force-pushed the fix_9893 branch 2 times, most recently from faa2876 to ee20a0a Compare July 26, 2024 07:19
@swq11
Copy link
Contributor Author

swq11 commented Jul 26, 2024

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jul 26, 2024

This pr cannot be merged! (status: blocked)

@swq11
Copy link
Contributor Author

swq11 commented Jul 29, 2024

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jul 29, 2024

This pr cannot be merged! (status: blocked)

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • performancemodecontroller.hperformancemodecontroller.cpp文件中,新增的宏定义BALANCEPERFORMANCE可能未在代码中使用,应确认是否必要。
  • 新增的BALANCEPERFORMANCE宏定义在powerapplet.hpowerapplet.cpp中重复定义,应检查是否需要删除或更新原有定义。
  • 新增的status-performance-mode_16px.svgstatus-performance-mode_24px.svg图标文件未在代码中使用,应确认是否必要,以及是否有相应的图标使用场景。
  • 代码中新增的图标文件status-performance-mode_16px.svgstatus-performance-mode_24px.svg的命名应遵循项目中现有的命名约定,例如使用icon-status-performance-mode.svg的格式。

是否建议立即修改:

@swq11
Copy link
Contributor Author

swq11 commented Jul 29, 2024

/merge

@deepin-bot deepin-bot bot merged commit 46b7ad1 into linuxdeepin:master Jul 29, 2024
@swq11 swq11 deleted the fix_9893 branch July 29, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants