Fix power and bluetooth cut in russian #371

hardWorker254 · 2025-09-24T19:03:37Z

linuxdeepin/developer-center#12262

Summary by Sourcery

Prevent UI text truncation in power and bluetooth plugins by dynamically sizing tip labels to fit rendered text

Bug Fixes:

Prevent power plugin tips from being truncated by setting the label's minimum width to the rendered text width
Prevent bluetooth plugin tips from being truncated by setting the label's minimum width to the rendered text width

deepin-ci-robot · 2025-09-24T19:03:50Z

Hi @hardWorker254. Thanks for your PR. 😃

deepin-ci-robot · 2025-09-24T19:03:52Z

Hi @hardWorker254. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions · 2025-09-24T19:03:53Z

CLA Assistant Lite bot:

如果你是以企业贡献者的身份进行提交，请联系我们签署企业贡献者许可协议
If you submit as corporate contributor, please contact us to sign our Corporate Contributor License Agreement

感谢您的提交，我们非常感谢。像许多开源项目一样，在接受您的贡献之前，我们要求您签署我们的个人贡献者许可协议。您只需发布与以下格式相同的评论即可签署个人贡献者许可协议。
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Individual Contributor License Agreement before we can accept your contribution. You can sign the Individual Contributor License Agreement by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA.

_{You can retrigger this bot by commenting recheck in this Pull Request}

sourcery-ai · 2025-09-24T19:04:02Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR ensures that power and Bluetooth tip labels fully display localized text by using QFontMetrics to calculate the rendered text width and setting the label’s minimum width accordingly, alongside minor formatting tweaks in the loadPlugin function.

Sequence diagram for BluetoothItem tips label width adjustment

sequenceDiagram
    participant BluetoothItem
    participant QLabel as "m_tipsLabel"
    participant QFontMetrics
    BluetoothItem->>QLabel: setText(tipsText)
    BluetoothItem->>QFontMetrics: QFontMetrics(m_tipsLabel.font())
    BluetoothItem->>QFontMetrics: boundingRect(m_tipsLabel.text())
    QFontMetrics-->>BluetoothItem: QRect (width)
    BluetoothItem->>QLabel: setMinimumWidth(textWidth)

File-Level Changes

Change	Details	Files
Add dynamic width adjustment for power tips label	Compute tip text width via QFontMetrics after setting label text Apply setMinimumWidth(textWidth) to m_tipsLabel	`plugins/dde-dock/power/powerplugin.cpp`
Add dynamic width adjustment for Bluetooth tips label	Compute tip text width via QFontMetrics after setting label text Apply setMinimumWidth(textWidth) to m_tipsLabel	`plugins/dde-dock/bluetooth/bluetoothitem.cpp`
Minor formatting tweaks in loadPlugin	Inserted blank lines to improve code readability in loadPlugin	`plugins/dde-dock/power/powerplugin.cpp`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

deepin-ci-robot · 2025-09-25T03:05:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, hardWorker254

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

Pull Request Overview

Fixes text truncation issues in Russian language UI for power and bluetooth dock plugins by dynamically calculating and setting minimum label widths based on rendered text dimensions.

Adds dynamic width calculation for tip labels in both power and bluetooth plugins
Prevents UI text truncation by ensuring labels are sized to accommodate their content
Addresses localization issues where longer translated text was being cut off

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
plugins/dde-dock/power/powerplugin.cpp	Adds font metrics calculation and minimum width setting for power plugin tip labels
plugins/dde-dock/bluetooth/bluetoothitem.cpp	Adds font metrics calculation and minimum width setting for bluetooth plugin tip labels

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-25T05:35:33Z

plugins/dde-dock/power/powerplugin.cpp

+    m_tipsLabel->setText(tips); 
+    QFontMetrics metrics(m_tipsLabel->font());
+    int textWidth = metrics.boundingRect(m_tipsLabel->text()).width();
+    m_tipsLabel->setMinimumWidth(textWidth);


[nitpick] Consider adding padding to the calculated width to ensure proper visual spacing. The current implementation sets the minimum width exactly to the text width, which may result in text appearing cramped against the label edges.

Suggested change

m_tipsLabel->setMinimumWidth(textWidth);

const int horizontalPadding = 8; // pixels

m_tipsLabel->setMinimumWidth(textWidth + horizontalPadding);

Copilot · 2025-09-25T05:35:34Z

plugins/dde-dock/bluetooth/bluetoothitem.cpp

    m_tipsLabel->setText(tipsText);
+    QFontMetrics metrics(m_tipsLabel->font());
+    int textWidth = metrics.boundingRect(m_tipsLabel->text()).width();
+    m_tipsLabel->setMinimumWidth(textWidth);


[nitpick] Consider adding padding to the calculated width to ensure proper visual spacing. The current implementation sets the minimum width exactly to the text width, which may result in text appearing cramped against the label edges.

Suggested change

m_tipsLabel->setMinimumWidth(textWidth);

const int horizontalPadding = 12; // Add 12px padding for better visual spacing

m_tipsLabel->setMinimumWidth(textWidth + horizontalPadding);

deepin-bot · 2025-09-25T12:57:14Z

TAG Bot

New tag: 2.0.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #372

BLumia · 2025-09-26T16:18:09Z

Thanks for your contribution! ❤️

hardWorker254 added 2 commits September 24, 2025 23:00

Add files via upload

12d3685

Add files via upload

d7af550

deepin-ci-robot added the needs-ok-to-test label Sep 24, 2025

sourcery-ai bot reviewed Sep 24, 2025

View reviewed changes

18202781743 approved these changes Sep 25, 2025

View reviewed changes

18202781743 requested a review from Copilot September 25, 2025 05:35

Copilot AI reviewed Sep 25, 2025

View reviewed changes

BLumia merged commit 66a98ee into linuxdeepin:master Sep 26, 2025
4 of 6 checks passed

deepin-ci-robot mentioned this pull request Oct 16, 2025

chore: bump version to 2.0.13 #374

Merged

	m_tipsLabel->setMinimumWidth(textWidth);
	const int horizontalPadding = 8; // pixels
	m_tipsLabel->setMinimumWidth(textWidth + horizontalPadding);

	m_tipsLabel->setMinimumWidth(textWidth);
	const int horizontalPadding = 12; // Add 12px padding for better visual spacing
	m_tipsLabel->setMinimumWidth(textWidth + horizontalPadding);

Fix power and bluetooth cut in russian #371

Fix power and bluetooth cut in russian #371

Uh oh!

Conversation

hardWorker254 commented Sep 24, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

deepin-ci-robot commented Sep 24, 2025

Uh oh!

deepin-ci-robot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai bot commented Sep 24, 2025

Reviewer's Guide

Sequence diagram for BluetoothItem tips label width adjustment

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

deepin-ci-robot commented Sep 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

deepin-bot bot commented Sep 25, 2025

Uh oh!

Uh oh!

BLumia commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hardWorker254 commented Sep 24, 2025 •

edited by sourcery-ai bot

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading