Skip to content

Conversation

@yixinshark
Copy link
Contributor

as title.

Log: as title
Influence: left mouse clicking quickItem

@yixinshark yixinshark force-pushed the fix-clickingQuickItem branch 2 times, most recently from 20a7d7e to 72039c9 Compare August 6, 2024 12:15
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

as title.

Log: as title
Influence: left mouse clicking quickItem
@yixinshark yixinshark force-pushed the fix-clickingQuickItem branch from 72039c9 to 44abbcb Compare August 6, 2024 12:39
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • PluginItem::isForceUndock函数中,pluginFlag参数应该使用const int类型,以避免潜在的类型转换问题。
  • WidgetPlugin::getPluginFlags函数中,对pluginsItemInterfaceV2->flags()的调用应该在pluginsItemInterfaceV2不为空的前提下进行。
  • WidgetPlugin::getPluginFlags函数中,对m_pluginInstance->property("pluginFlags")的调用应该在m_pluginInstance不为空的前提下进行。
  • QuickPluginItem::mouseReleaseEvent函数中,对executeCommand()的调用应该在e->button() == Qt::LeftButton的前提下进行。
  • QuickPluginItem::pluginContextMenu函数中,对isForceUndock(flags)的调用应该在flags不为零的前提下进行。

是否建议立即修改:

@deepin-bot
Copy link

deepin-bot bot commented Aug 6, 2024

TAG Bot

New tag: 0.0.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #118

@yixinshark
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 6, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit fe99cdc into linuxdeepin:master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants