Skip to content

Conversation

@yixinshark
Copy link
Contributor

1.Reduce tooltip window flicker
2.adaptive content width

Log: as title
Issue: linuxdeepin/developer-center#10043
Influence: tooltip display

1.Reduce tooltip window flicker
2.adaptive content width

Log: as title
Issue: linuxdeepin/developer-center#10043
Influence: tooltip display
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • BrightnessItem::init()函数中,m_tipsLabel的初始化逻辑被移到了updateTips()函数中,这可能影响tipsWidget()的返回结果。需要确认这是否是预期的行为。
  • BrightnessItem::updateTips()函数中,tips字符串的格式化使用了QString("%1: %2%<br/>"),但在最后添加了一个换行符\n。这可能不是预期的行为,因为<br/>通常用于表示换行,而在这里它似乎只是添加了一个空格。需要确认这是否是预期的格式。
  • PluginItem::itemTooltip()函数中,toolTip的固定大小设置逻辑被修改,以检查sizeHint()是否为空,并且只有在大小不匹配时才进行调整。这可能会影响tooltip的大小,需要确认这是否是预期的行为。

是否建议立即修改:

  • 是,需要确认上述更改是否符合预期功能,并确保它们不会引入新的问题。

@deepin-bot
Copy link

deepin-bot bot commented Jul 31, 2024

TAG Bot

New tag: 0.0.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #102

@yixinshark yixinshark closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants