Skip to content

Conversation

@tsic404
Copy link
Contributor

@tsic404 tsic404 commented Aug 14, 2024

log: as title

@tsic404 tsic404 requested a review from wineee August 14, 2024 06:05
@tsic404 tsic404 marked this pull request as draft August 14, 2024 06:05
@deepin-bot
Copy link

deepin-bot bot commented Aug 15, 2024

TAG Bot

New tag: 0.0.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #699

@tsic404 tsic404 force-pushed the panel/dock/treeland branch 2 times, most recently from 777c612 to 40fa497 Compare August 15, 2024 09:04
@tsic404 tsic404 force-pushed the panel/dock/treeland branch from 40fa497 to f63c67e Compare August 23, 2024 07:32
@tsic404 tsic404 marked this pull request as ready for review August 23, 2024 07:32
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404
Copy link
Contributor Author

tsic404 commented Aug 23, 2024

/test all

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • AppItem.qml中,onEnteredonTriggered事件的条件判断中增加了对Qt.platform.pluginName的检查,这可能是为了在不同的平台下正确地处理事件。需要确认这一改动的必要性。
  • treelandwindowmonitor.cpp中,m_hideTimer的间隔时间被修改为800毫秒,这可能是为了更好地控制预览窗口的显示和隐藏。需要验证这一改动是否符合预期的用户体验。
  • treelandwindowmonitor.cpp中,QVarLengthArray被替换为QByteArray来存储窗口ID,这可能是为了优化内存使用和性能。需要验证这一改动是否符合预期的性能要求。
  • treelandwindowmonitor.h中,TreeLandDockPreviewContext类被声明为私有的,这可能是为了防止外部代码意外地使用该类。需要验证这一改动是否符合项目的封装要求。

是否建议立即修改:

  • 是,需要确保这些更改是基于实际需求和测试的结果,并且不会引入新的问题。特别是对于性能和封装的考虑,需要特别注意。

@tsic404
Copy link
Contributor Author

tsic404 commented Aug 23, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 23, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 37f4495 into linuxdeepin:master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants