Skip to content

Conversation

@tsic404
Copy link
Contributor

@tsic404 tsic404 commented Aug 6, 2024

log: as title

@tsic404 tsic404 force-pushed the tray-ani branch 2 times, most recently from 2256174 to 6b53d58 Compare August 6, 2024 08:50
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ActionToggleCollapseDelegate.qml中,icon.name的计算属性被简化,但可能影响原来的功能,需要确认是否符合预期。
  • TrayContainer.qml中,Behavioron widthon heightNumberAnimationeasing.typecollapsed状态时从Easing.OutQuad改为Easing.InQuad,这可能会改变动画的平滑度,需要确认是否符合设计要求。
  • TrayItemPositioner.qml中,PropertyChangesscale属性被添加,但未提供对应的动画或逻辑说明其用途。
  • traysortordermodel.cpp中,currentVisualIndex的计算逻辑在m_collapsedtrue时改变了方向,这可能会影响排序顺序,需要验证新的逻辑是否正确。

是否建议立即修改:

  • 需要确认ActionToggleCollapseDelegate.qmlicon.name的简化是否符合预期功能。
  • 需要验证TrayContainer.qmlBehavioron widthon heightNumberAnimationeasing.type更改是否符合设计要求。
  • 需要提供TrayItemPositioner.qml中添加的scale属性的动画或逻辑说明,以确保其正确性。
  • 需要验证traysortordermodel.cppcurrentVisualIndex的逻辑更改是否不会影响排序顺序,并确保其正确性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Aug 6, 2024

TAG Bot

New tag: 0.0.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #656

@tsic404
Copy link
Contributor Author

tsic404 commented Aug 7, 2024

/test all

@tsic404
Copy link
Contributor Author

tsic404 commented Aug 7, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 7, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit f77b093 into linuxdeepin:master Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants