Skip to content

Conversation

@justforlxz
Copy link
Member

@justforlxz justforlxz commented Mar 25, 2024

No description provided.

@justforlxz justforlxz marked this pull request as draft March 25, 2024 06:11
@deepin-bot
Copy link

deepin-bot bot commented Mar 28, 2024

TAG Bot

TAG: 1.2.9
EXISTED: no
DISTRIBUTION: unstable

@deepin-bot
Copy link

deepin-bot bot commented Apr 10, 2024

TAG Bot

New tag: 1.2.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #76

@deepin-bot
Copy link

deepin-bot bot commented Apr 25, 2024

TAG Bot

New tag: 1.2.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #78

@justforlxz justforlxz changed the title WIP chore: add dde-session.target.wants chore: move dde-session@x11 to dde-session-pre.target Apr 28, 2024
@justforlxz justforlxz marked this pull request as ready for review April 28, 2024 01:38
@justforlxz justforlxz requested review from BLumia and dengbo11 April 28, 2024 01:39
BLumia
BLumia previously approved these changes Apr 28, 2024
some service like kwin or treeland needs running before DDE

Log:
dengbo11
dengbo11 previously approved these changes Apr 28, 2024
@dengbo11
Copy link
Contributor

@justforlxz 可以先提集成让测试测下, 看有没有啥问题

release 1.2.9

Log:
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz
Copy link
Member Author

/topic dde-session-x11

@deepin-ci-robot
Copy link

Add topic: dde-session-x11 successed.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 删除了dde-session@wayland.service文件,但未提供替代实现或说明删除的原因。
  • dde-session@x11.service中,RefuseManualStartRefuseManualStop被取消,但没有解释为什么需要这样做。
  • ExecCondition被添加到dde-session@x11.service,但未提供对应的条件判断,可能会导致不必要的服务启动。
  • ExecStopPostdde-session@x11.service中被添加,取消了环境变量WAYLAND_DISPLAYDISPLAY的设置,但没有解释为什么需要这样做。

是否建议立即修改:

建议立即修改的原因是,上述问题可能会影响DDE session服务的正常工作,包括可能的不必要启动和环境变量配置的丢失,这可能会导致运行时错误。需要澄清为什么需要这些更改,并确保它们是必要的。如果删除dde-session@wayland.service是有意为之,建议添加相应的替代逻辑或提供详细说明。

@justforlxz
Copy link
Member Author

/integr-topic dde-session-x11

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1351

@justforlxz
Copy link
Member Author

/integr-topic dde-session-x11

@deepin-ci-robot
Copy link

Alreadly latest topic integration with deepin-community/Repository-Integration#1351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants