Optimize some calls and correct typos #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asterwyx
commented
Jan 4, 2024
asterwyx
commented
- Use QMetaObject::invokeMethod
- Correct typo found
Contributor
|
TAG Bot New tag: 6.0.26 |
tsic404
reviewed
Jan 4, 2024
asterwyx
force-pushed
the
chores
branch
2 times, most recently
from
875ce92 to
50ed8e4
Compare
Use invokeMethod to invoke method in event loop later. Log: use invokeMethod instead of singleShot
Correct typo founded to found. Log: correct typo
Correct indentation to 4 spaces. Log: correct indentation
tsic404
approved these changes
Jan 4, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asterwyx, tsic404 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.