Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Aug 12, 2025

  • 更新 go.mod 以包含 go-gir 的相关更新
  • 更新 README 移除不再使用的联系方式
  • 更新 transifex cli 配置文件以供推拉翻译

Edit: 此 PR 已不再需要,详见 #858 (comment)

Summary by Sourcery

Update dependency versions, clean up documentation, and refresh translation configuration

Build:

  • Bump linuxdeepin/go-dbus-factory, go-gir, and go-lib versions in go.mod

Documentation:

  • Remove obsolete startdde entry and deprecated Gitter/IRC contact links from README and its Chinese translation

Chores:

  • Update Transifex CLI configuration (.tx/config) for translation push/pull
  • Regenerate go.sum after dependency bumps

@BLumia BLumia requested a review from fly602 August 12, 2025 09:00
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BLumia - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR bumps Go module dependency versions, cleans up obsolete references in README files, and updates the Transifex CLI configuration for translation synchronization.

File-Level Changes

Change Details Files
Bump Go module dependencies
  • Updated go-dbus-factory version
  • Updated go-gir version
  • Updated go-lib version
go.mod
go.sum
Clean up README contact info and dependencies
  • Removed startdde from build dependencies
  • Removed Gitter contact link
  • Removed IRC channel link
README.md
README.zh_CN.md
Refresh Transifex CLI configuration
  • Updated .tx/config settings for translation syncing
.tx/config

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@BLumia BLumia marked this pull request as draft August 12, 2025 09:05
@BLumia
Copy link
Member Author

BLumia commented Aug 12, 2025

更新 go.mod 以包含 go-gir 的相关更新
更新 README 移除不再使用的联系方式
更新 transifex cli 配置文件以供推拉翻译

Log:
@BLumia BLumia marked this pull request as ready for review August 14, 2025 05:11
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. .tx/config 文件中的 minimum_perc 配置项从 0 改为 80,需要确认这一改动是否符合项目的翻译策略和需求。
  2. .tx/config 文件中 source_langen 改为 en_US,需要确认这是否是必要的,并且确保所有相关的翻译文件和工具都支持这种格式。
  3. README.mdREADME.zh_CN.md 文件中删除了对 startdde 的引用,需要确认这是否是必要的,因为 startdde 可能是项目的一部分或依赖项。
  4. go.modgo.sum 文件中更新了依赖项的版本,需要确认这些版本更新是否已经通过了所有必要的测试,并且不会引入任何兼容性问题。
  5. go.sum 文件中删除了 github.com/linuxdeepin/go-dbus-factorygithub.com/linuxdeepin/go-girgithub.com/linuxdeepin/go-lib 的旧版本,需要确保这些删除操作不会影响项目的构建和运行。

总体来说,这些改动看起来是合理的,但需要进一步确认每个改动的具体原因和影响。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 15, 2025

TAG Bot

New tag: 6.1.50
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #862

@BLumia
Copy link
Member Author

BLumia commented Aug 15, 2025

进度见 #858 (comment) ,此 PR 对 go.mod 的升级已涵盖在 17ecf84 ,故已不再需要此 PR。

@BLumia BLumia closed this Aug 15, 2025
@BLumia BLumia deleted the gomod branch August 15, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants