Skip to content

Conversation

@fly602
Copy link
Contributor

@fly602 fly602 commented Jan 28, 2026

update changelog to 6.1.73

Summary by Sourcery

Update Debian changelog for the 6.1.73 release.

Documentation:

  • Refresh the Debian changelog entry to document version 6.1.73.

Chores:

  • Align project metadata with version 6.1.73.

update changelog to 6.1.73
@github-actions
Copy link

TAG Bot

TAG: 6.1.73
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Debian packaging metadata to bump the package version to 6.1.73 in the changelog.

File-Level Changes

Change Details Files
Bump Debian package version to 6.1.73 in the changelog.
  • Update the latest changelog entry to reflect version 6.1.73
  • Adjust associated metadata (e.g., date, maintainer entry, or distribution field) if included in the updated stanza
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段 debian/changelog 的 diff 记录显示了 dde-daemon 包从版本 6.1.72 升级到 6.1.73 的变更内容。以下是对该变更的审查意见,涵盖语法逻辑、代码质量、代码规范以及潜在的安全和性能考量。

1. 语法与格式审查

  • 日期异常(严重)

    • 问题:日期显示为 Wed, 28 Jan 2026
    • 意见:这是一个未来的年份(2026年)。除非这是为了测试未来版本的发布流程,否则这是一个明显的错误。Debian/Ubuntu 打包系统通常允许未来的时间戳,但这会导致该版本在当前系统上被视为"未发布"或产生混淆。
    • 建议:请修正为当前的实际日期(例如 2024 或 2025 年)。
  • 语言混用(规范性)

    • 问题:变更条目中同时使用了英文和中文。
      • feat: support configurable password encryption algorithms (英文)
      • fix: 修复插拔触控屏,触摸屏绑定关系会丢失问题 (中文)
    • 意见:虽然 dpkg 处理中文没有问题,但在国际化项目的 Changelog 中保持语言一致性是最佳实践。如果项目主要面向国际化或上游社区,建议统一使用英文;如果仅面向内部中文发布,统一使用中文亦可。
    • 建议:建议将中文条目翻译为英文,例如:
      • fix: fix the loss of touchscreen binding relationship when plugging/unplugging

2. 代码逻辑与功能审查

  • feat: support configurable password encryption algorithms

    • 审查:这是一个功能性增强。
    • 安全建议:既然涉及密码加密算法,请确保:
      • 默认算法是安全的(如 Argon2, bcrypt 或 PBKDF2)。
      • 避免使用过时或不安全的算法(如 MD5, SHA1)作为默认值或唯一选项。
      • 配置变更是否需要重启守护进程才能生效?如果是,应在文档或提交说明中注明。
  • feat: add polkit authorization for system services

    • 审查:增加了权限控制。
    • 安全建议:这是非常好的安全实践。请审查新增的 Polkit 策略文件,确保:
      • 没有过度授权(例如允许普通用户无需认证即可修改关键系统设置)。
      • allow_activeallow_any 的使用是否恰当。
  • fix: 修复插拔触控屏,触摸屏绑定关系会丢失问题

    • 审查:修复了硬件热插拔时的状态管理问题。
    • 逻辑建议:触控屏通常与特定的显示器输出相关联。插拔时需要确保udev规则或监听逻辑能正确识别设备ID并重新应用映射配置。建议检查修复方案是否处理了多显示器场景下的设备归属问题。
  • fix: add wheel speed value validation in setWheelSpeed

    • 审查:增加了参数校验。
    • 健壮性建议:这是一个防御性编程的改进。请确保验证范围合理(例如不能为负数,或不超过硬件支持的最大物理速度),并且当输入非法值时,函数有明确的错误返回值或日志记录,而不是静默失败。

3. 代码性能考量

  • 本次变更主要涉及配置、权限校验和硬件事件处理,不太可能引入明显的全局性能瓶颈。
  • 针对 polkit authorization:确保高频调用的 D-Bus 方法不会因为每次都触发 Polkit 检查而导致明显的延迟。如果是高频操作,考虑缓存权限检查结果或在设计上减少鉴权频率。

4. 总结与改进建议

  1. 修正日期:务必将 2026 修正为当前实际年份。
  2. 统一语言:建议将 Changelog 条目统一翻译为英文,以符合开源社区规范。
  3. 安全审查:重点审查新增的"密码加密算法配置"和"Polkit 策略",确保没有引入安全漏洞。
  4. 测试建议
    • 测试触控屏反复插拔场景,确认配置持久化。
    • 测试 setWheelSpeed 传入边界值(极大值、负值、非数字)时的系统表现。

修正后的 Changelog 示例(建议):

+dde-daemon (6.1.73) unstable; urgency=medium
+
+  * feat: support configurable password encryption algorithms
+  * feat: add polkit authorization for system services
+  * fix: fix the loss of touchscreen binding relationship when plugging/unplugging
+  * fix: add wheel speed value validation in setWheelSpeed
+
+ -- fuleyi <fuleyi@uniontech.com>  Wed, 28 Jan 2024 15:05:46 +0800

@fly602 fly602 merged commit d0d1ed0 into linuxdeepin:master Jan 28, 2026
18 checks passed
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 28, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.1.73
  • Tag SHA: c1e507756b490ab296cc67e7c4c74da89cdab6bb
  • Commit SHA: 7ddc1c0dd2b1178ec4157275488e072384518ae1
  • Tag Message:
    Release dde-daemon 6.1.73
    
    
  • Tagger:
    • Name: fly602
  • Distribution: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants