-
Notifications
You must be signed in to change notification settings - Fork 143
fix: update fingerprint enrollment error handling and UI logic #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review这段代码主要是关于指纹认证功能的修改,涉及到了版权年份更新、错误提示信息优化、状态逻辑修复以及对话框生命周期管理。以下是对代码的详细审查意见: 1. 整体评价代码主要针对指纹录入流程中的异常处理和UI交互进行了优化。整体逻辑清晰,能够解决在特定场景下(如录入失败后)状态不一致或UI刷新异常的问题。 2. 详细审查意见2.1 版权信息更新位置: 所有文件头部 -//SPDX-FileCopyrightText: 2025 UnionTech Software Technology Co., Ltd.
+//SPDX-FileCopyrightText: 2025 - 2026 UnionTech Software Technology Co., Ltd.意见:
2.2 错误提示文案优化位置: - QString msg = "";
+ QString msg = tr("Scan suspended");意见:
2.3 失败状态下的UI资源处理位置: + m_fingertipImagePath = "user_biometric_fingerprint_lose";意见:
2.4 状态检查防止无效操作位置: + if (m_addStage == CharaMangerModel::Fail || m_addStage == CharaMangerModel::Success) {
+ return;
+ }意见:
2.5 对话框非活跃时停止录入位置: + onActiveChanged: function() {
+ if (listview.currentIndex == 1 && !active) {
+ dccData.fingerprintController.stopEnroll()
+ }
+ }意见:
3. 总结该次修改主要提升了指纹录入功能的稳定性和用户体验。
总体而言,代码改动是安全且必要的,逻辑清晰。建议在合并前重点关注 QML 部分的交互逻辑是否符合实际产品需求。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Updated copyright year from 2025 to 2025-2026 across multiple files 2. Removed Chinese comments from abstract class header file (AbstractBiometricController.h) to maintain code consistency 3. Fixed fingerprint enrollment error message - changed from empty string to "Scan suspended" when enrollment fails 4. Added fingerprint image path update on enrollment failure to show appropriate visual feedback 5. Added safety checks in timer and animation handlers to prevent unnecessary updates when enrollment is already in Fail or Success state 6. Added dialog window active state handling to stop fingerprint enrollment when dialog becomes inactive during enrollment process Log: Improved fingerprint enrollment error handling with proper visual feedback and state management fix: 更新指纹录入错误处理和UI逻辑 1. 将多个文件的版权年份从2025更新为2025-2026 2. 从抽象类头文件中移除中文注释以保持代码一致性 3. 修复指纹录入错误消息 - 当录入失败时从空字符串改为"扫描已暂停" 4. 在录入失败时添加指纹图像路径更新以显示适当的视觉反馈 5. 在定时器和动画处理程序中添加安全检查,防止在录入已处于失败或成功状态 时进行不必要的更新 6. 添加对话框窗口活动状态处理,在录入过程中对话框变为非活动状态时停止指 纹录入 Log: 改进了指纹录入错误处理,提供适当的视觉反馈和状态管理 PMS: BUG-306585
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Log: Improved fingerprint enrollment error handling with proper visual feedback and state management
fix: 更新指纹录入错误处理和UI逻辑
Log: 改进了指纹录入错误处理,提供适当的视觉反馈和状态管理
PMS: BUG-306585