Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Oct 31, 2024

Adapt to the Treeland protocol

Log: As Title
Task: https://pms.uniontech.com/task-view-365811.html

@mhduiy mhduiy force-pushed the mergeTreeland-per branch 12 times, most recently from 8e0f05d to 714daa0 Compare November 1, 2024 02:50

find_package(Qt6 REQUIRED COMPONENTS WaylandClient)

set(Enable_TreelandSupport ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set(Enable_TreelandSupport CACHE ON STRING "Enable_TreelandSupport")

@mhduiy mhduiy force-pushed the mergeTreeland-per branch from 714daa0 to e8019a3 Compare November 1, 2024 03:13
@mhduiy mhduiy requested a review from kegechen November 1, 2024 03:13
kegechen
kegechen previously approved these changes Nov 1, 2024
@deepin-bot
Copy link

deepin-bot bot commented Nov 1, 2024

TAG Bot

New tag: 6.0.72
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1760

@mhduiy mhduiy force-pushed the mergeTreeland-per branch from ddce3ff to 13dfcaa Compare November 1, 2024 05:15
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • CMakeLists.txt中,find_package命令的组件名称应与实际使用的Qt模块名称一致,例如WaylandClient而不是WaylandClientPrivate
  • ImageHelper::isDarkType函数中,对图像大小的检查可能不够健壮,建议增加对图像大小的验证。
  • PersonalizationWorker类中的onWallpaperUrlsChanged函数被重载,但未在所有子类中实现,可能会导致运行时错误。
  • TreeLandWorker类中,setWallpaper函数中的QFile操作可能需要处理文件不存在或无法打开的情况。
  • WallpaperSelectView.qml中,右键点击事件处理逻辑可能需要更详细的错误处理,以避免潜在的崩溃。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
Copy link
Contributor Author

mhduiy commented Nov 1, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Nov 1, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit fb47ad3 into linuxdeepin:master Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants