Skip to content

Conversation

@ArchieMeng
Copy link
Contributor

Bug: https://pms.uniontech.com/bug-view-271571.html
Log: incorrect bluetooth device icon theme type

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Sep 13, 2024

TAG Bot

New tag: 6.0.66
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1715

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • BluetoothDeviceModel::data函数中,新增代码逻辑可能存在逻辑错误,isDarkTheme变量在case Qt::DecorationRole中被重新赋值,可能导致原有逻辑失效。
  • BluetoothDeviceModel::getBatteryIcon函数中,iconNameSystem的计算逻辑与isDarkTheme变量有关,但注释中提到"-dark"与暗主题无关,这可能与代码逻辑不一致。
  • 新增代码中没有对themeType的值进行有效性检查,可能会导致未处理的初始化错误。

是否建议立即修改:

@ArchieMeng
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Sep 18, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit d41654d into linuxdeepin:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants