Skip to content

Conversation

@yixinshark
Copy link
Contributor

as title

Log: as title
Issue: linuxdeepin/developer-center#10398

@deepin-bot
Copy link

deepin-bot bot commented Aug 15, 2024

TAG Bot

New tag: 6.0.62
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1674

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SearchWidget::onAutoComplete函数中,m_completer->complete(rect().adjusted(0, 0, 0, 8));可能会导致不必要的性能开销,因为adjusted方法会创建一个新的QRect对象,而不是直接修改原始的rect对象。
  • 代码中的str.remove(' ');可能会导致用户输入中的空格被删除,这可能不是预期的行为,应该确认是否需要删除空格。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit 559732d into linuxdeepin:master Aug 15, 2024
kegechen pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants