chore: tidy up the flow #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TAG Bot New tag: 1.1.9 |
Decodetalkers
force-pushed
the
flowbigchange
branch
from
a65dbc4 to
b4464ce
Compare
Decodetalkers
force-pushed
the
flowbigchange
branch
from
b4464ce to
8ff4a29
Compare
Contributor
Author
|
/integrate |
|
AutoIntegrationPr Bot |
kegechen
reviewed
Jan 2, 2024
Decodetalkers
force-pushed
the
flowbigchange
branch
from
8ff4a29 to
552992d
Compare
Contributor
Author
|
/integrate |
Decodetalkers
force-pushed
the
flowbigchange
branch
3 times, most recently
from
df1ff74 to
7ac0e28
Compare
dengbo11
reviewed
Jan 5, 2024
| const QString wallpaperJsonPath = QString("%1/dde-appearance/").arg(utils::GetUserConfigDir()); | ||
| const static QString wallpaperJsonPath = QString("%1/dde-appearance/").arg(utils::GetUserConfigDir()); | ||
|
|
||
| static void writeWallpaperConfig(const QVariant &wallpaper) |
Contributor
There was a problem hiding this comment.
这个函数放到modules/api/utils.h中
Decodetalkers
force-pushed
the
flowbigchange
branch
from
7ac0e28 to
2b338f8
Compare
1. check the value when dconfig changed, this will make set not do twice 2. write config file before write to dconfig. Because dde-desktop listen to dconfig, so we should update config before dconfig changed. And base config need to be changed before write new dconfig Log:
Decodetalkers
force-pushed
the
flowbigchange
branch
from
2b338f8 to
a4708ab
Compare
dengbo11
approved these changes
Jan 5, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Decodetalkers, dengbo11 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.