-
Notifications
You must be signed in to change notification settings - Fork 37
chore: remove startdde dependency #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove startdde dependency Log: remove startdde dependency pms: TASK-374777
Reviewer's Guide by SourceryThis pull request removes the Updated class diagram for Appearance1ThreadclassDiagram
class Appearance1Thread{
-QString qtActivecolor
-QString qtDarkActivecolor
-int radius
+Appearance1Thread()
}
note for Appearance1Thread "Replaced STARTCDDEAPPID with DDEDAEMONAPPID in constructor"
Updated class diagram for AppearanceManagerclassDiagram
class AppearanceManager{
-QSharedPointer<DConfig> m_XSettingsDconfig
+AppearanceManager()
}
note for AppearanceManager "Replaced STARTCDDEAPPID with DDEDAEMONAPPID in constructor"
Updated class diagram for ThemesApiclassDiagram
class ThemesApi{
-QSharedPointer<DConfig> xSetting
+ThemesApi()
+~ThemesApi()
}
note for ThemesApi "Replaced STARTCDDEAPPID with DDEDAEMONAPPID in constructor"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
综上所述,这些更改需要仔细测试和验证,以确保它们不会对系统的稳定性和功能产生负面影响。同时,建议在代码中添加适当的注释和文档,以便其他开发者能够更好地理解这些更改的背景和目的。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fly602 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're replacing
STARTCDDEAPPIDwithDDEDAEMONAPPID- can you confirm this is the correct replacement?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot TAG: 1.1.57 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
remove startdde dependency
Log: remove startdde dependency
pms: TASK-374777
Summary by Sourcery
Chores: