Skip to content

fix: control center window effects cannot be control #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justforlxz merged 2 commits into from
Jul 9, 2024
Merged

fix: control center window effects cannot be control #113

justforlxz merged 2 commits into from
Jul 9, 2024

Conversation

@zorowk
Copy link

@zorowk zorowk commented Jun 28, 2024 •
edited
Loading

Bug:
linuxdeepin/developer-center#7912
linuxdeepin/developer-center#9068
linuxdeepin/developer-center#9041

Log: fix control center window effects cannot be control

@zorowk zorowk force-pushed the fix_9068 branch 2 times, most recently from bf7d762 to 55f1956 Compare July 1, 2024 03:39
@github-actions
Copy link

github-actions bot commented Jul 3, 2024

TAG Bot

TAG: 1.1.29
EXISTED: no
DISTRIBUTION: unstable

@wineee

This comment was marked as duplicate.

Sign in to view
@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 3, 2024

Integrated with pr deepin-community/Repository-Integration#1538

wineee
wineee requested changes Jul 3, 2024
View reviewed changes
@wineee
Copy link
Member

wineee commented Jul 3, 2024

/topic kwin-1070

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 3, 2024

Add topic: kwin-1070 successed.

@wineee
Copy link
Member

wineee commented Jul 3, 2024

/integr-topic kwin-1070

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 3, 2024

Integrated with pr deepin-community/Repository-Integration#1538

@zorowk zorowk force-pushed the fix_9068 branch 2 times, most recently from f66e531 to d2c500f Compare July 4, 2024 05:59
@justforlxz
Copy link
Member

justforlxz commented Jul 4, 2024

/integr-topic kwin-1070

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 4, 2024

Integrated with pr deepin-community/Repository-Integration#1538

@justforlxz
Copy link
Member

justforlxz commented Jul 4, 2024

/integr-topic kwin-1070

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 4, 2024

Alreadly latest topic integration with deepin-community/Repository-Integration#1538

chore: bump version to 1.1.29
703b049 
Signed-off-by: pengwenhao <pengwenhao@uniontech.com>
@wineee
Copy link
Member

wineee commented Jul 8, 2024

/integr-topic kwin-1070

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 8, 2024

Integrated with pr deepin-community/Repository-Integration#1538

fix: control cetner set window effect
113c88b 
Signed-off-by: pengwenhao <pengwenhao@uniontech.com>
@zorowk
Copy link
Author

zorowk commented Jul 8, 2024

/integr-topic kwin-1070

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 8, 2024

deepin pr auto review

关键摘要:

  • 在enableEffect函数中，对kwin_active_effects的修改应该在调用toggleEffect或unloadEffect之前进行，以确保修改后的列表被正确使用。
  • enableEffect函数中的if (on)条件判断是多余的，因为toggleEffect和unloadEffect的调用逻辑已经包含了判断是否启用效果的功能。
  • setCompositingEnabled函数中的enableEffect调用应该在m_kwinConfig->sync();之后，以确保配置文件被正确更新。
  • setCompositingEnabled函数中的ResumeCompositorChanged(1);调用可能需要确认是否有必要在启用和禁用 compositor 时都调用。
  • maybeShowWarningDialog函数中的enable变量应该在循环外部定义，以确保在每次循环时都使用最新的 compositor 状态。
  • kwin_active_effects列表应该在类外部定义，以便在整个代码库中重用。

是否建议立即修改:
是

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 8, 2024

Integrated with pr deepin-community/Repository-Integration#1538

1 similar comment
@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 8, 2024

Integrated with pr deepin-community/Repository-Integration#1538

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, zorowk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz justforlxz merged commit e2352fe into linuxdeepin:master Jul 9, 2024
@deepin-bot deepin-bot bot mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wineee wineee wineee requested changes

@justforlxz justforlxz justforlxz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zorowk @wineee @deepin-ci-robot @justforlxz