GPG toolstack upgrade to latest available versions (Fixes Gawk issue)#714
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom May 22, 2020
Merged
Conversation
This was referenced May 4, 2020
Collaborator
Author
|
@MrChromebox Any opposition? |
MrChromebox
reviewed
May 18, 2020
Contributor
|
@tlaurion let me give this a test tomorrow, looks good at first glance outside of the unrelated x230 config change |
paulmenzel
reviewed
May 19, 2020
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
I tried to review this, but GitHub makes that quite hard (compared to Gerrit for example, used in coreboot).
I would like to see the changes below.
- Format and write git commit messages to follow the standard.
- Fix typos in the commit messages.
- Summarize the problems in the commit message instead of loosely referencing issues. Currently it’s hard to understand for outsiders, which do not follow the Heads development.
- Summarize the software version changes (overview) in the pull request description (also the gawk issue), and note how much the size changes.
- Mention in the commit messages, why certain configure options are changed (nls for example).
tlaurion
force-pushed
the
gawk_test_over_latest_debian
branch
3 times, most recently
from
c22ea2d to
9016e18
Compare
MrChromebox
reviewed
May 20, 2020
tlaurion
force-pushed
the
gawk_test_over_latest_debian
branch
2 times, most recently
from
08b4539 to
bc4013f
Compare
Collaborator
Author
|
only configure warning still being present is |
Contributor
|
built for librem13v4, flashed, booted, performed a factory reset and everything went smoothly. LGTM now |
tlaurion
force-pushed
the
gawk_test_over_latest_debian
branch
from
bc4013f to
7f657da
Compare
- Remove unrecognized configure options - fixes gawk issue linuxboot#668 by upgrading to libgpg-error 1.37 instead of patching 1.32 for regex change (fixed upstream) - move patches so they match new versions for libassuan, gpg and libgcrypt (no change) Version change: - gpg 2.2.10 -> 2.2.20 - libassuan 2.5.1 -> 2.5.3 - libgcrypt 1.8.3 -> 1.8.5 - libgpg-error 1.32 -> 1.37 Size changes: - gpg 886.5 -> 911.3 kB - gpg-agent: 371.9 -> 376.0 kB - scdaemon: 399.5 -> 407.8 kB - libgpg-error.so.0 125.9 -> 130.0 kB Unrecognized options on gpg2 toolstack: - disable-nls and disable-asm disable-keyserver-helpers disable-hkp disable-finger disable-dns-srv disable-dns-cert and disable-wks-server
tlaurion
force-pushed
the
gawk_test_over_latest_debian
branch
from
7f657da to
241b0bc
Compare
This was referenced May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes to be reverted CircleCi config to test current build over debian bullseye which was successful, while resulting build is currently untested.
Fixes #668 and problem in #710 PR to include Heads into Guix facing gawk issues
Todo: push additional commit to reverse that changeset once reviewed.
Reviewers:
I repeat here message in commit