Skip to content

Commit

Permalink
delete_module01: Cleanup style
Browse files Browse the repository at this point in the history
* remove unused import
* join string to be on single line
* use C style comparison in if
* reuse constant

Signed-off-by: Petr Vorel <pvorel@suse.cz>
  • Loading branch information
pevik committed Jul 18, 2023
1 parent fd72497 commit 2369408
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions testcases/kernel/syscalls/delete_module/delete_module01.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,27 @@
* Install dummy_del_mod.ko and delete it with delete_module(2).
*/

#include <errno.h>
#include "tst_test.h"
#include "tst_module.h"
#include "lapi/syscalls.h"

#define MODULE_NAME "dummy_del_mod"
#define MODULE_NAME_KO "dummy_del_mod.ko"
#define MODULE_NAME_KO MODULE_NAME ".ko"

static int module_loaded;

static void do_delete_module(void)
{
if (module_loaded == 0) {
if (!module_loaded) {
tst_module_load(MODULE_NAME_KO, NULL);
module_loaded = 1;
}

TEST(tst_syscall(__NR_delete_module, MODULE_NAME, 0));
if (TST_RET == -1) {
tst_res(TFAIL | TTERRNO, "delete_module() failed to "
"remove module entry for %s ", MODULE_NAME);
tst_res(TFAIL | TTERRNO,
"delete_module() failed to remove module entry for %s",
MODULE_NAME);
return;
}

Expand All @@ -44,7 +44,7 @@ static void do_delete_module(void)

static void cleanup(void)
{
if (module_loaded == 1)
if (module_loaded)
tst_module_unload(MODULE_NAME_KO);
}

Expand Down

0 comments on commit 2369408

Please sign in to comment.