Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix multiple small issues in README.md #456

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

vojtechtrefny
Copy link
Collaborator

@vojtechtrefny vojtechtrefny commented Jul 17, 2024

Missing information about Stratis support, default value for grow_to_fill, notes about pool type-specific arguments etc.

Resolves: #455
Resolves: #428
Resolves: #385
Related: #437

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.76%. Comparing base (bb51979) to head (5e93dab).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (bb51979) and HEAD (5e93dab). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (bb51979) HEAD (5e93dab)
sanity 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   16.54%   10.76%   -5.79%     
==========================================
  Files           2        8       +6     
  Lines         284     1942    +1658     
  Branches       79        0      -79     
==========================================
+ Hits           47      209     +162     
- Misses        237     1733    +1496     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richm
Copy link
Contributor

richm commented Jul 17, 2024

what about addressing concerns in #437 and #428 and #385

@vojtechtrefny vojtechtrefny force-pushed the main_readme-fixes branch 2 times, most recently from a937d76 to a10aeba Compare July 17, 2024 16:25
@vojtechtrefny
Copy link
Collaborator Author

what about addressing concerns in #437 and #428 and #385

Good point, I've updated the PR to cover these issues too.

Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments,
partitioning support, formatting etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@richm richm merged commit 06844b5 into linux-system-roles:main Jul 17, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants