test: lvm pool members test fix #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 16.54% 11.64% -4.91%
==========================================
Files 2 8 +6
Lines 284 1795 +1511
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1586 +1349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[citest] |
|
Sounds like it should be a |
vojtechtrefny
approved these changes
Jun 6, 2024
japokorn
changed the title
tests_lvm_pool_members started to fail. It tried to create a device with a requested size (20m) that was less than minimal allowed size (300m) for that type of volume. Role automatically resized the device to allowed size. That lead to discrepancy in actual and expected size values. Increasing the requested device size to be same or larger than minimal fixes the issue.
japokorn
force-pushed
the
main-min_size_test_fix
branch
from
323a410
to
64d6890
Compare
|
Changed PR name and commit message to start with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests_lvm_pool_members started to fail. It tried to create a device with a requested size (20m) that was less than minimal allowed size (300m) for that type of volume. Role automatically resized the device to allowed size. That lead to discrepancy in actual and expected size values.
Increasing the requested device size to be same or larger than minimal fixes the issue.