ci: ansible-lint - ignore var-naming[no-role-prefix] #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible-lint has recently added a check for this. It flags a lot of our test code, and some of our role code that uses nested roles. There is no easy way to disable it for these cases only. It would be a tremendous amount of work to add `# noqa` comments everywhere. The use of `.ansible-lint-ignore` would be a maintenance burden (cannot use tests/tests_*.yml or other similar wildcard to match all test files), would still issue a lot of warning messages, and would not solve all of the problems. The only way for now is to skip this rule. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 13.70% 13.70%
=======================================
Files 8 8
Lines 1729 1729
Branches 71 71
=======================================
Hits 237 237
Misses 1492 1492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansible-lint has recently added a check for this. It flags a lot of our test
code, and some of our role code that uses nested roles.
There is no easy way to disable it for these cases only. It would be a
tremendous amount of work to add
# noqacomments everywhere.The use of
.ansible-lint-ignorewould be a maintenance burden (cannot usetests/tests_*.yml or other similar wildcard to match all test files), would
still issue a lot of warning messages, and would not solve all of the problems.
The only way for now is to skip this rule.
Signed-off-by: Rich Megginson rmeggins@redhat.com