Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-lint - use changed_when for conditional tasks; add line length comment #344

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

richm
Copy link
Contributor

@richm richm commented Apr 7, 2023

ansible-lint now requires the use of changed_when even for
conditional tasks

Add yamllint line-length suppression

Signed-off-by: Rich Megginson rmeggins@redhat.com

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01781d5) 13.90% compared to head (042e2fe) 13.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   13.90%   13.90%           
=======================================
  Files           8        8           
  Lines        1705     1705           
  Branches       71       71           
=======================================
  Hits          237      237           
  Misses       1468     1468           
Flag Coverage Δ
sanity 16.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…h comment

ansible-lint now requires the use of changed_when even for
conditional tasks

Add yamllint line-length suppression

Fix jinja spacing

Use descriptive task names

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm
Copy link
Contributor Author

richm commented Apr 7, 2023

[citest]

1 similar comment
@richm
Copy link
Contributor Author

richm commented Apr 10, 2023

[citest]

Copy link
Contributor

@spetrosi spetrosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richm
Copy link
Contributor Author

richm commented Apr 11, 2023

[citest]

@richm
Copy link
Contributor Author

richm commented Apr 12, 2023

[citest]

@richm richm merged commit 7126d8d into linux-system-roles:main Apr 13, 2023
@richm richm deleted the more-ansible-lint branch April 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants