Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow role to work with gather_facts: false #262

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

richm
Copy link
Contributor

@richm richm commented Apr 8, 2022

Allow the role to work if the playbook has set gather_facts: false.
The gather_subset: min includes all of the facts used by this
role. Other roles may need to gather more facts.
The role gathers the facts where they are needed. Other roles may
need to gather facts in a different place.

Copy link
Contributor

@nhosoi nhosoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

A good candidate to add to the template and the best-practices?

@richm
Copy link
Contributor Author

richm commented Apr 8, 2022

lgtm

A good candidate to add to the template and the best-practices?

Yes.

Copy link
Collaborator

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Allow the role to work if the playbook has set `gather_facts: false`.
The `gather_subset: min` includes all of the facts used by this
role.  Other roles may need to gather more facts.
The role gathers the facts where they are needed.  Other roles may
need to gather facts in a different place.
@richm richm merged commit 3d22f1c into linux-system-roles:master Apr 11, 2022
@richm richm deleted the no-gather-facts branch April 11, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants