-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add setup snapshot to install packages into snapshot #260
Conversation
The goal here is that we can create a snapshot of the VM image pre-loaded with packages that take a long time to install like kmod-kvdo, then use that snapshot for subsequent tests. The main thing this PR does is to allow test playbooks access to the inner variables of the role, e.g. the list of packages per-platform. This is currently only enabled for the ansible 2.12 test runner (the rhel7 runner qemu guest crashes when trying to use the snapshot) the test runner will need to be changed to use tests/setup-snapshot.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A bit confused that these files are not related to the "snapshot"; just added because they were missing?
tests/tests_create_lvm_cache_then_remove_nvme_generated.yml
tests/tests_create_lvm_cache_then_remove_scsi_generated.yml
tests/tests_fatals_cache_volume_nvme_generated.yml
tests/tests_fatals_cache_volume_scsi_generated.yml
yes - the tests/tests_create_lvm_cache_then_remove_nvme_generated.yml tests/tests_create_lvm_cache_then_remove_scsi_generated.yml tests/tests_fatals_cache_volume_nvme_generated.yml tests/tests_fatals_cache_volume_scsi_generated.yml |
My bad, that should have been part of #235. I have added a short paragraph about the generated tests to README-devel (#261) so I should remember it next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[citest] |
No description provided.