Trim volume size as needed to fit in pool free space #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwlehman
force-pushed
the
trim-volume-size
branch
2 times, most recently
from
9b132aa
to
9069389
Compare
|
This should resolve #13 |
|
[citest bad] |
dwlehman
force-pushed
the
trim-volume-size
branch
from
d95ecf6
to
dddf749
Compare
|
[citest bad] |
|
[citest bad] |
We could verify that there is no more extra files from previous PRs, e.g., with |
japokorn
reviewed
Feb 20, 2021
This adds a mechanism for trimming requested volume sizes so that they fit in their pool. The intention is to accommodate small shortages arising from metadata space usage, eg: creating a lvm pool on an unpartitioned 10GiB drive and trying to create a single 100GiB volume in that pool. There is no reason a user of this role should have to learn about LVM's metadata usage. The maximum reduction of the volume size is 10% of the requested size.
Playbook will fail when lv size is equal to vg size Signed-off-by: Changhui Zhong <czhong@redhat.com>
dwlehman
force-pushed
the
trim-volume-size
branch
from
dddf749
to
50a3801
Compare
|
Latest revision added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included the test from #189 since it is intended to verify this change.
I am open to a discussion of whether we should expose
MAX_TRIM_PERCENTin the role defaults. I'm also open to discussion of what the best default value is. I would definitely be open to reducing it to 2-4% as that's more in line with my intended application of this.