feat: support custom config files with logging_custom_config_files #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
force-pushed
the
improve-support-for-custom
branch
from
1af0bbf
to
025b7be
Compare
|
[citest] |
Feature: Allow users to provide custom logging configuration files using the new variable `logging_custom_config_files` which is a list of config files to copy to the default logging configuration directory. For example, this directory for rsyslog is `/etc/rsyslog.d/`. This assumes the logging configuration will load all files matching `*.conf` in this directory as in the default rsyslog directive `$IncludeConfig /etc/rsyslog.d/*.conf`. Reason: Users need customized configuration not not provided by the role. The role allowed this previously by the use of the variable `rsyslog_custom_config_files`, but that variable was intended to be used privately and is now marked DEPRECATED. Result: Users can provide custom configuration in a supported manner. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
force-pushed
the
improve-support-for-custom
branch
from
025b7be
to
a78707e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Allow users to provide custom logging configuration files
using the new variable
logging_custom_config_fileswhich is a listof config files to copy to the default logging configuration directory.
For example, this directory for rsyslog is
/etc/rsyslog.d/. Thisassumes the logging configuration will load all files matching
*.confin this directory as in the default rsyslog directive
$IncludeConfig /etc/rsyslog.d/*.conf.Reason: Users need customized configuration not provided by the role.
The role allowed this previously by the use of the variable
rsyslog_custom_config_files, but that variable was intended to be usedprivately and is now marked DEPRECATED.
Result: Users can provide custom configuration in a supported manner.
Signed-off-by: Rich Megginson rmeggins@redhat.com