Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for configuring node attributes #184

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

tomjelinek
Copy link
Member

Enhancement:
Add support for configuring node attributes

Reason:
Node attributes are used in resource constraints

Result:
It is now possible to configure node attributes using the role

Issue Tracker Tickets (Jira or BZ if any):

@tomjelinek
Copy link
Member Author

[citest]

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2450454) 0.00% compared to head (4d6f7b0) 76.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #184       +/-   ##
=========================================
+ Coverage      0   76.79%   +76.79%     
=========================================
  Files         0        3        +3     
  Lines         0      181      +181     
  Branches      0       12       +12     
=========================================
+ Hits          0      139      +139     
- Misses        0       42       +42     
Flag Coverage Δ
sanity 50.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek
Copy link
Member Author

[citest]

@tomjelinek
Copy link
Member Author

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xd4 in position 34: invalid continuation byte errors in tests_cib_node_attributes.yml are caused by pacemaker bug RHEL-23498 and RHEL-23065. There is nothing the role can do about that.

@richm richm changed the title feat: add support for configurong node attributes feat: add support for configuring node attributes Feb 7, 2024
@richm richm merged commit 47ec1d2 into linux-system-roles:main Feb 7, 2024
27 of 34 checks passed
@tomjelinek tomjelinek deleted the node-attrs branch February 8, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting cluster members' attributes.
2 participants