style: followup for recent ansible-lint related changes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Python 2 bits as minimal supported version is Python 3.9 - silence linters for incomplete stub classes for failed imports - minor type annotations fixes
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 76.53% 76.79% +0.25%
==========================================
Files 3 3
Lines 179 181 +2
Branches 12 12
==========================================
+ Hits 137 139 +2
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # pylint: enable=no-name-in-module | ||
| try: | ||
| from pcs.common.async_tasks.dto import CommandDto, CommandOptionsDto | ||
| except ImportError: | ||
| HAS_PCS = False | ||
| PCS_IMPORT_ERROR = traceback.format_exc() | ||
| PCS_IMPORT_ERROR: Optional[str] = traceback.format_exc() |
Check notice
Code scanning / CodeQL
Unused global variable Note
| # pylint: enable=no-name-in-module | ||
| try: | ||
| from pcs.common.async_tasks.dto import CommandDto, CommandOptionsDto | ||
| except ImportError: | ||
| HAS_PCS = False | ||
| PCS_IMPORT_ERROR = traceback.format_exc() | ||
| PCS_IMPORT_ERROR: Optional[str] = traceback.format_exc() |
Check notice
Code scanning / CodeQL
Unused global variable Note
tomjelinek
changed the title
tomjelinek
changed the title
|
[citest] |
richm
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates downstream GitLab CI configuration to match changes done to upstream CI to support recent ansible-lint. It also fixes issues reported by woke, isort, pylint and mypy linters.